Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754875AbdGUWRV (ORCPT ); Fri, 21 Jul 2017 18:17:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdGUWRU (ORCPT ); Fri, 21 Jul 2017 18:17:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 04D8E61B82 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 04D8E61B82 Subject: Re: [PATCH] staging: vboxvideo: make a couple of symbols static To: Colin King , Greg Kroah-Hartman , Michael Thayer , Daniel Vetter , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170719093616.9853-1-colin.king@canonical.com> From: Hans de Goede Message-ID: <5af53a54-9ca3-702e-909f-e27e56bf855b@redhat.com> Date: Sat, 22 Jul 2017 00:17:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170719093616.9853-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 21 Jul 2017 22:17:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1737 Lines: 56 Hi, On 19-07-17 11:36, Colin King wrote: > From: Colin Ian King > > Module parameter vbox_modeset and structure vbox_bo_driver do not need to > be in global scope and hence can be made static. > > Cleans up a couple of sparse warnings: > symbol 'vbox_modeset' was not declared. Should it be static? > symbol 'vbox_bo_driver' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Looks good to me: Acked-by: Hans de Goede Regards, Hans > --- > drivers/staging/vboxvideo/vbox_drv.c | 2 +- > drivers/staging/vboxvideo/vbox_ttm.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vboxvideo/vbox_drv.c b/drivers/staging/vboxvideo/vbox_drv.c > index 6d0600c37c0c..e18642e5027e 100644 > --- a/drivers/staging/vboxvideo/vbox_drv.c > +++ b/drivers/staging/vboxvideo/vbox_drv.c > @@ -36,7 +36,7 @@ > > #include "vbox_drv.h" > > -int vbox_modeset = -1; > +static int vbox_modeset = -1; > > MODULE_PARM_DESC(modeset, "Disable/Enable modesetting"); > module_param_named(modeset, vbox_modeset, int, 0400); > diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c > index 34a905d40735..4eb410a2a1a8 100644 > --- a/drivers/staging/vboxvideo/vbox_ttm.c > +++ b/drivers/staging/vboxvideo/vbox_ttm.c > @@ -230,7 +230,7 @@ static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm) > ttm_pool_unpopulate(ttm); > } > > -struct ttm_bo_driver vbox_bo_driver = { > +static struct ttm_bo_driver vbox_bo_driver = { > .ttm_tt_create = vbox_ttm_tt_create, > .ttm_tt_populate = vbox_ttm_tt_populate, > .ttm_tt_unpopulate = vbox_ttm_tt_unpopulate, >