Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754918AbdGUWqR (ORCPT ); Fri, 21 Jul 2017 18:46:17 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:44446 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdGUWqQ (ORCPT ); Fri, 21 Jul 2017 18:46:16 -0400 From: "Rafael J. Wysocki" To: "Gustavo A. R. Silva" Cc: Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: speedstep: remove unnecessary static in speedstep_detect_chipset() Date: Sat, 22 Jul 2017 00:38:22 +0200 Message-ID: <1908499.SpSD1enk2O@aspire.rjw.lan> User-Agent: KMail/4.14.10 (Linux/4.12.0-rc1+; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20170705030921.GA18166@embeddedgus> References: <20170705030921.GA18166@embeddedgus> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1854 Lines: 65 On Tuesday, July 04, 2017 10:09:21 PM Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable hostbridge. > Such variable is initialized before being used, > on every execution path throughout the function. > The static has no benefit and, removing it reduces > the code size. > > This issue was detected using Coccinelle and the following semantic patch: > > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > > In the following log you can see the difference in the code size. Also, > there is a significant difference in the bss segment. This log is the > output of the size command, before and after the code change: > > before: > text data bss dec hex filename > 5084 3392 256 8732 221c drivers/cpufreq/speedstep-ich.o > > after: > text data bss dec hex filename > 5062 3304 192 8558 216e drivers/cpufreq/speedstep-ich.o > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/cpufreq/speedstep-ich.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/speedstep-ich.c b/drivers/cpufreq/speedstep-ich.c > index b86953a..0412a24 100644 > --- a/drivers/cpufreq/speedstep-ich.c > +++ b/drivers/cpufreq/speedstep-ich.c > @@ -207,7 +207,7 @@ static unsigned int speedstep_detect_chipset(void) > * 8100 which use a pretty old revision of the 82815 > * host bridge. Abort on these systems. > */ > - static struct pci_dev *hostbridge; > + struct pci_dev *hostbridge; > > hostbridge = pci_get_subsys(PCI_VENDOR_ID_INTEL, > PCI_DEVICE_ID_INTEL_82815_MC, > Applied, thanks!