DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 78495C057FA5
Date: Sat, 22 Jul 2017 07:43:27 +0800
From: Baoquan He <bhe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, keescook@chromium.org,
        matt@codeblueprint.co.uk, tglx@linutronix.de, hpa@zytor.com,
        izumi.taku@jp.fujitsu.com, fanc.fnst@cn.fujitsu.com,
        thgarnie@google.com, n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be
 randomized in mirror regions
Message-ID: <20170721234327.GA24530@x1>
References: <1500542189-15779-1-git-send-email-bhe@redhat.com>
 <20170721103757.hc74czr3mfunrv6c@gmail.com>
 <20170721131956.GK2344@x1>
 <20170721173753.54mn7udl6byzq2yh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170721173753.54mn7udl6byzq2yh@gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 779
Lines: 23

On 07/21/17 at 07:37pm, Ingo Molnar wrote:
> 
> * Baoquan He <bhe@redhat.com> wrote:
> 
> > > > +static inline bool process_efi_entries(unsigned long minimum,
> > > > +				       unsigned long image_size)
> > > 
> > > ugly linebreak again ...
> > 
> > The whole line is more than 80. I break the line and use tab and space
> > to make it align with above 'unsigned long minimum'. Don't know why it
> > becomes messy in patch. Will check and try again.
> 
> Then make the linebreak less ugly, or ignore the checkpatch warning!
> 
> This commonly used pattern:
> 
>   static inline bool
>   process_efi_entries(unsigned long minimum, unsigned long image_size)
> 
> looks a lot better than the function parameter list broken in the middle.

Got it, will use this one. Thanks a lot!