Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754926AbdGUXoy (ORCPT ); Fri, 21 Jul 2017 19:44:54 -0400 Received: from mail-yw0-f173.google.com ([209.85.161.173]:35611 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdGUXow (ORCPT ); Fri, 21 Jul 2017 19:44:52 -0400 MIME-Version: 1.0 In-Reply-To: <20170721225815.i6467grjen32x4kq@gmail.com> References: <20170721225815.i6467grjen32x4kq@gmail.com> From: Dan Williams Date: Fri, 21 Jul 2017 16:44:51 -0700 Message-ID: Subject: Re: Moving ndctl development into the kernel tree? To: Ingo Molnar Cc: "torvalds@linux-foundation.org" , Johannes Thumshirn , jmoyer , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , Arnaldo Carvalho de Melo , "Oliver O'Halloran" , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 20 On Fri, Jul 21, 2017 at 3:58 PM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> [...] >> >> * Like perf, ndctl borrows the sub-command architecture and option >> parsing from git. So, this code could be refactored into something >> shared / generic, i.e. the bits in tools/perf/util/. > > Just as a side note, stacktool (tools/stacktool/) is using the Git sub-command and > options parsing code as well, and it's already sharing it with perf, via the > tools/lib/subcmd/ library. > > ndctl could use that as well. Ah, nice, that refactoring happened about a year after ndctl was born. Which brings up the next question about what to do with the git history, but I'd want to know if ndctl is even welcome upstream before digging any deeper.