Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752229AbdGVHYK (ORCPT ); Sat, 22 Jul 2017 03:24:10 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26690 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbdGVHYI (ORCPT ); Sat, 22 Jul 2017 03:24:08 -0400 Subject: Re: [PATCH] staging: vboxvideo: make a couple of symbols static To: Hans de Goede , Colin King , Greg Kroah-Hartman , Daniel Vetter , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170719093616.9853-1-colin.king@canonical.com> <5af53a54-9ca3-702e-909f-e27e56bf855b@redhat.com> From: Michael Thayer Organization: ORACLE Deutschland B.V. und Co. KG Message-ID: <3541f5b7-b355-c15b-153f-50c609ba3298@oracle.com> Date: Sat, 22 Jul 2017 09:22:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <5af53a54-9ca3-702e-909f-e27e56bf855b@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2505 Lines: 71 22.07.2017 00:17, Hans de Goede wrote: > Hi, > > On 19-07-17 11:36, Colin King wrote: >> From: Colin Ian King >> >> Module parameter vbox_modeset and structure vbox_bo_driver do not need to >> be in global scope and hence can be made static. >> >> Cleans up a couple of sparse warnings: >> symbol 'vbox_modeset' was not declared. Should it be static? >> symbol 'vbox_bo_driver' was not declared. Should it be static? >> >> Signed-off-by: Colin Ian King > > Looks good to me: > > Acked-by: Hans de Goede Looks good to me too. Sorry for the slow response. Still had no time to actually apply it, but as said, it looks completely sensible. Regards Michael Acked-by: Michael Thayer >> --- >> drivers/staging/vboxvideo/vbox_drv.c | 2 +- >> drivers/staging/vboxvideo/vbox_ttm.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/vboxvideo/vbox_drv.c >> b/drivers/staging/vboxvideo/vbox_drv.c >> index 6d0600c37c0c..e18642e5027e 100644 >> --- a/drivers/staging/vboxvideo/vbox_drv.c >> +++ b/drivers/staging/vboxvideo/vbox_drv.c >> @@ -36,7 +36,7 @@ >> #include "vbox_drv.h" >> -int vbox_modeset = -1; >> +static int vbox_modeset = -1; >> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting"); >> module_param_named(modeset, vbox_modeset, int, 0400); >> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c >> b/drivers/staging/vboxvideo/vbox_ttm.c >> index 34a905d40735..4eb410a2a1a8 100644 >> --- a/drivers/staging/vboxvideo/vbox_ttm.c >> +++ b/drivers/staging/vboxvideo/vbox_ttm.c >> @@ -230,7 +230,7 @@ static void vbox_ttm_tt_unpopulate(struct ttm_tt >> *ttm) >> ttm_pool_unpopulate(ttm); >> } >> -struct ttm_bo_driver vbox_bo_driver = { >> +static struct ttm_bo_driver vbox_bo_driver = { >> .ttm_tt_create = vbox_ttm_tt_create, >> .ttm_tt_populate = vbox_ttm_tt_populate, >> .ttm_tt_unpopulate = vbox_ttm_tt_unpopulate, >> -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher