Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755185AbdGVKb7 (ORCPT ); Sat, 22 Jul 2017 06:31:59 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35775 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdGVKb6 (ORCPT ); Sat, 22 Jul 2017 06:31:58 -0400 Subject: Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value To: gregkh@linuxfoundation.org Cc: linux@Wolf-Entwicklungen.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170722102734.653-1-paolocretaro@gmail.com> From: Paolo Cretaro Message-ID: Date: Sat, 22 Jul 2017 12:31:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170722102734.653-1-paolocretaro@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 28 On 22/07/2017 12:27, Paolo Cretaro wrote: > Fix compiler warning: ordered comparison of pointer with integer zero Sorry, just noticed a similar patch has been submitted a few days ago, please ignore this patch. Paolo > > Signed-off-by: Paolo Cretaro > --- > drivers/staging/pi433/pi433_if.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index 1bc478a7f49e..79bd19123239 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi) > device->tx_task_struct = kthread_run(pi433_tx_thread, > device, > "pi433_tx_task"); > - if (device->tx_task_struct < 0) > + if (IS_ERR(device->tx_task_struct)) > { > dev_dbg(device->dev, "start of send thread failed"); > goto send_thread_failed; >