Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755229AbdGVL5Y (ORCPT ); Sat, 22 Jul 2017 07:57:24 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:47551 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753602AbdGVL5W (ORCPT ); Sat, 22 Jul 2017 07:57:22 -0400 From: Gabriel FERNANDEZ To: Stephen Boyd , Vladimir Zapolskiy CC: Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre TORGUE , Michael Turquette , Nicolas Pitre , Arnd Bergmann , "daniel.thompson@linaro.org" , "andrea.merello@gmail.com" , "radoslaw.pietrzyk@gmail.com" , Lee Jones , "Sylvain Lemieux" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Ludovic BARRE , "Olivier BIDEAU" , Amelie DELAUNAY , "gabriel.fernandez.st@gmail.com" , "Arvind Yadav" Subject: Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver Thread-Topic: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver Thread-Index: AQHTAJrtnO3TSWU6nUubz30yFHqT2qJbhvAAgAC7jQCAADe2AIACJVIAgAEA1QA= Date: Sat, 22 Jul 2017 11:56:26 +0000 Message-ID: <3173625b-9183-41b2-228d-ef3a5271b4a9@st.com> References: <1500474344-9832-1-git-send-email-gabriel.fernandez@st.com> <1500474344-9832-4-git-send-email-gabriel.fernandez@st.com> <11c37627-a39b-7f2d-d0d4-af312eac8668@st.com> <20170721203712.GH19878@codeaurora.org> In-Reply-To: <20170721203712.GH19878@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.48] Content-Type: text/plain; charset="utf-8" Content-ID: <1322052012D2F547B4F74469550B107B@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-22_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6MBvci6029763 Content-Length: 1648 Lines: 43 On 07/21/2017 10:37 PM, Stephen Boyd wrote: > On 07/20, Vladimir Zapolskiy wrote: >> Hi Gabriel, >> >> On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote: >>> Hi Vladimir, >>> >>> >>> On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: >>>> Hello Gabriel, >>>> >>>> On 07/19/2017 05:25 PM, gabriel.fernandez@st.com wrote: >>>>> From: Gabriel Fernandez >>>>> + >>>>> + rcc: rcc@58024400 { >>>> 'rcc' as a generic device node name is awkward. >>>> >>>> I believe the main function of the device is clock controller (unlikely >>>> a generic reset controller can be converted into a clock controller), >>>> the locations of the document and device driver also indicate that >>>> primarily it is a clock controller, so I suggest to replace device node >>>> name with 'clock-controller' like below: >>> I prefer to keep rcc node name, to be coherent with the other ST >>> platforms (STM32F4/F7) >> the thing is, a device node name is expected to comply with ePAPR or >> the devicetree specification, which says >> >> The name of a node should be somewhat generic, reflecting >> the function of the device and not its precise programming model. >> >> If devicetree and CCF maintainers are fine with 'rcc', I won't object, >> my role is just to emphasize the found issue and recommend to use another >> and more common name 'clock-controller', it is a simple and fortunately >> backward compatible change to other ST platforms as well. > Yes. It should be generic so clock-controller or > clock-reset-controller is appropriate here. > ok i will change order... reset-clock-controller name to match with rcc. Best Regards Gabriel