Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753516AbdGVNMb (ORCPT ); Sat, 22 Jul 2017 09:12:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58280 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbdGVNM3 (ORCPT ); Sat, 22 Jul 2017 09:12:29 -0400 Date: Sat, 22 Jul 2017 14:46:30 +0200 From: Greg Kroah-Hartman To: Pavel Shilovskiy Cc: Ben Hutchings , "linux-kernel@vger.kernel.org" , Sachin Prabhu , "stable@vger.kernel.org" Subject: Re: [PATCH 3.18 36/68] Handle mismatched open calls Message-ID: <20170722124630.GA6774@kroah.com> References: <20170505183212.587141964@linuxfoundation.org> <20170505183214.050929158@linuxfoundation.org> <1500050552.2707.145.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1826 Lines: 46 On Wed, Jul 19, 2017 at 06:39:13PM +0000, Pavel Shilovskiy wrote: > 2017-07-14 9:43 Ben Hutchings : > > On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote: > > > 3.18-stable review patch.??If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Sachin Prabhu > > > > > > commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream. > > [...] > > > --- a/fs/cifs/smb2ops.c > > > +++ b/fs/cifs/smb2ops.c > > > @@ -1461,6 +1461,8 @@ struct smb_version_operations smb21_oper > > > ? .clear_stats = smb2_clear_stats, > > > ? .print_stats = smb2_print_stats, > > > ? .is_oplock_break = smb2_is_valid_oplock_break, > > > + .handle_cancelled_mid = smb2_handle_cancelled_mid, > > > + .handle_cancelled_mid = smb2_handle_cancelled_mid, > > > ? .downgrade_oplock = smb2_downgrade_oplock, > > > ? .need_neg = smb2_need_neg, > > > ? .negotiate = smb2_negotiate, > > > @@ -1542,6 +1544,8 @@ struct smb_version_operations smb30_oper > > > ? .print_stats = smb2_print_stats, > > > ? .dump_share_caps = smb2_dump_share_caps, > > > ? .is_oplock_break = smb2_is_valid_oplock_break, > > > + .handle_cancelled_mid = smb2_handle_cancelled_mid, > > > + .handle_cancelled_mid = smb2_handle_cancelled_mid, > > > ? .downgrade_oplock = smb2_downgrade_oplock, > > > ? .need_neg = smb2_need_neg, > > > ? .negotiate = smb2_negotiate, > > [...] > > > > This doesn't look right. handle_cancelled_mid should be initialised once in each of the 3 smb_version_operations structures, shouldn't it? > > > > Ben. > > Yes, you are right. Thanks for pointing it out. > > Greg, I provided the patch to fix the above bug (see the attachment). > Could you please look at it and apply to the 3.18.x kernel if it is > suitable? Looks good, now queued up, thanks. greg k-h