Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752214AbdGVSRs (ORCPT ); Sat, 22 Jul 2017 14:17:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47164 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbdGVSRr (ORCPT ); Sat, 22 Jul 2017 14:17:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A826A80462 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A826A80462 Subject: Re: [PATCH] staging: vboxvideo: remove unused variables To: Paolo Cretaro , gregkh@linuxfoundation.org Cc: michael.thayer@oracle.com, daniel@ffwll.ch, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170722105553.12540-1-paolocretaro@gmail.com> From: Hans de Goede Message-ID: Date: Sat, 22 Jul 2017 20:17:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170722105553.12540-1-paolocretaro@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sat, 22 Jul 2017 18:17:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1720 Lines: 52 Hi, On 22-07-17 12:55, Paolo Cretaro wrote: > Fix compiler warnings: > vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used > vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used > > Signed-off-by: Paolo Cretaro Patch looks good to me: Acked-by: Hans de Goede Regards, Hans > --- > drivers/staging/vboxvideo/vbox_mode.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c > index f2b85f3256fa..a7eea70a3804 100644 > --- a/drivers/staging/vboxvideo/vbox_mode.c > +++ b/drivers/staging/vboxvideo/vbox_mode.c > @@ -54,14 +54,12 @@ static void vbox_do_modeset(struct drm_crtc *crtc, > struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc); > struct vbox_private *vbox; > int width, height, bpp, pitch; > - unsigned int crtc_id; > u16 flags; > s32 x_offset, y_offset; > > vbox = crtc->dev->dev_private; > width = mode->hdisplay ? mode->hdisplay : 640; > height = mode->vdisplay ? mode->vdisplay : 480; > - crtc_id = vbox_crtc->crtc_id; > bpp = crtc->enabled ? CRTC_FB(crtc)->format->cpp[0] * 8 : 32; > pitch = crtc->enabled ? CRTC_FB(crtc)->pitches[0] : width * bpp / 8; > x_offset = vbox->single_framebuffer ? crtc->x : vbox_crtc->x_hint; > @@ -578,9 +576,6 @@ static int vbox_mode_valid(struct drm_connector *connector, > > static void vbox_connector_destroy(struct drm_connector *connector) > { > - struct vbox_connector *vbox_connector; > - > - vbox_connector = to_vbox_connector(connector); > drm_connector_unregister(connector); > drm_connector_cleanup(connector); > kfree(connector); >