Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbdGVSwm (ORCPT ); Sat, 22 Jul 2017 14:52:42 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:38646 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdGVSwl (ORCPT ); Sat, 22 Jul 2017 14:52:41 -0400 Subject: Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency To: Arnd Bergmann , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Hans Verkuil , Russell King , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170721162144.3339864-1-arnd@arndb.de> From: Steve Longerbeam Message-ID: Date: Sat, 22 Jul 2017 11:52:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170721162144.3339864-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1160 Lines: 27 Acked-by: Steve Longerbeam On 07/21/2017 09:21 AM, Arnd Bergmann wrote: > Without this, I get a build error: > > drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt': > drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? [-Werror=implicit-function-declaration] > > Fixes: e130291212df ("[media] media: Add i.MX media core driver") > Signed-off-by: Arnd Bergmann > --- > drivers/staging/media/imx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig > index 7eff50bcea39..719508fcb0e9 100644 > --- a/drivers/staging/media/imx/Kconfig > +++ b/drivers/staging/media/imx/Kconfig > @@ -1,6 +1,7 @@ > config VIDEO_IMX_MEDIA > tristate "i.MX5/6 V4L2 media core driver" > depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE > + depends on VIDEO_V4L2_SUBDEV_API > select V4L2_FWNODE > ---help--- > Say yes here to enable support for video4linux media controller >