Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754017AbdGWKQY (ORCPT ); Sun, 23 Jul 2017 06:16:24 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24827 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbdGWKQX (ORCPT ); Sun, 23 Jul 2017 06:16:23 -0400 Subject: Re: [PATCH] staging: vboxvideo: remove unused variables To: Hans de Goede , Paolo Cretaro , gregkh@linuxfoundation.org Cc: daniel@ffwll.ch, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170722105553.12540-1-paolocretaro@gmail.com> From: Michael Thayer Organization: ORACLE Deutschland B.V. und Co. KG Message-ID: <5b033c2b-6d23-8c9f-b3e4-7ab253d905f6@oracle.com> Date: Sun, 23 Jul 2017 12:16:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2660 Lines: 80 Hello, 22.07.2017 20:17, Hans de Goede wrote: > Hi, > > On 22-07-17 12:55, Paolo Cretaro wrote: >> Fix compiler warnings: >> vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used >> vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used >> >> Signed-off-by: Paolo Cretaro > > Patch looks good to me: > > Acked-by: Hans de Goede This is more or less copied and pasted from my reply to Colin King's patch on the 19th, but it applies equally here. Looks good to me too. Not had time to actually apply it yet, but as said, it looks completely sensible. Regards Michael Acked-by: Michael Thayer > Regards, > > Hans > > >> --- >> drivers/staging/vboxvideo/vbox_mode.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/staging/vboxvideo/vbox_mode.c >> b/drivers/staging/vboxvideo/vbox_mode.c >> index f2b85f3256fa..a7eea70a3804 100644 >> --- a/drivers/staging/vboxvideo/vbox_mode.c >> +++ b/drivers/staging/vboxvideo/vbox_mode.c >> @@ -54,14 +54,12 @@ static void vbox_do_modeset(struct drm_crtc *crtc, >> struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc); >> struct vbox_private *vbox; >> int width, height, bpp, pitch; >> - unsigned int crtc_id; >> u16 flags; >> s32 x_offset, y_offset; >> vbox = crtc->dev->dev_private; >> width = mode->hdisplay ? mode->hdisplay : 640; >> height = mode->vdisplay ? mode->vdisplay : 480; >> - crtc_id = vbox_crtc->crtc_id; >> bpp = crtc->enabled ? CRTC_FB(crtc)->format->cpp[0] * 8 : 32; >> pitch = crtc->enabled ? CRTC_FB(crtc)->pitches[0] : width * bpp >> / 8; >> x_offset = vbox->single_framebuffer ? crtc->x : vbox_crtc->x_hint; >> @@ -578,9 +576,6 @@ static int vbox_mode_valid(struct drm_connector >> *connector, >> static void vbox_connector_destroy(struct drm_connector *connector) >> { >> - struct vbox_connector *vbox_connector; >> - >> - vbox_connector = to_vbox_connector(connector); >> drm_connector_unregister(connector); >> drm_connector_cleanup(connector); >> kfree(connector); >> -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher