Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbdGWMLP (ORCPT ); Sun, 23 Jul 2017 08:11:15 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20274 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbdGWMLO (ORCPT ); Sun, 23 Jul 2017 08:11:14 -0400 Date: Sun, 23 Jul 2017 15:10:53 +0300 From: Dan Carpenter To: Johan Hovold Cc: Shreeya Patel , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. Message-ID: <20170723121053.b2sjrdsenkzjetti@mwanda> References: <1500799197-4326-1-git-send-email-shreeya.patel23498@gmail.com> <20170723084743.GF2729@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170723084743.GF2729@localhost> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 632 Lines: 16 On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote: > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > > Alignment should match with open parenthesis. > > This fixes the coding style issue. > > No, it need not. This is a choice left up to the author, even if > checkpatch happens to complain about it with the --strict option. > This is staging code. Don't try to fight checkpatch.pl in staging... You're just making work for everyone else (me) who already just reviewed this patch and I don't want to review it a few more times when the next person sends the exact same patch. regards, dan carpenter