Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755325AbdGWPx2 (ORCPT ); Sun, 23 Jul 2017 11:53:28 -0400 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:27494 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbdGWPx1 (ORCPT ); Sun, 23 Jul 2017 11:53:27 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 23 Jul 2017 17:53:24 +0200 X-ME-IP: 90.16.81.74 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , Russell King , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/12] ARM: sa1100/pxa: fix MTD_XIP build References: <20170720154616.3250481-1-arnd@arndb.de> <20170720155209.3250880-1-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 23 Jul 2017 17:53:03 +0200 In-Reply-To: <20170720155209.3250880-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 20 Jul 2017 17:51:42 +0200") Message-ID: <871sp7rvz4.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 747 Lines: 25 Arnd Bergmann writes: Hi Arnd, > -#define xip_irqpending() (ICIP & ICMR) > +/* restored July 2017, this did not build since 2011! */ > + > +#define ICIP io_p2v(0x40d00000) > +#define ICMR io_p2v(0x40d00004) Okay, I suppose the IO mapping is guaranteed to work, ie. io_p2v() is behaving correctly when xip_irqpending() is used, right ? I'm not challenging this, I'm just ensuring this _could_ work (if anybody had the silly idea to make it work again, and I admit I don't have that much courage). > +#define xip_irqpending() readl(ICIP) & readl(ICMR) This is not strictly equivalent to (ICIP & ICMR), I would have put for priority reasons : +#define xip_irqpending() (readl(ICIP) & readl(ICMR)) ..zip.. Cheers. -- Robert