Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755431AbdGWR0L (ORCPT ); Sun, 23 Jul 2017 13:26:11 -0400 Received: from mail-pg0-f44.google.com ([74.125.83.44]:33557 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755368AbdGWR0J (ORCPT ); Sun, 23 Jul 2017 13:26:09 -0400 Date: Sun, 23 Jul 2017 10:26:01 -0700 From: Stephen Hemminger To: Salil Mehta Cc: , , , , , , , , Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Message-ID: <20170723102601.18ac81a1@xeon-e3> In-Reply-To: <20170722220942.78852-8-salil.mehta@huawei.com> References: <20170722220942.78852-1-salil.mehta@huawei.com> <20170722220942.78852-8-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 19 On Sat, 22 Jul 2017 23:09:41 +0100 Salil Mehta wrote: > + HNS3_NETDEV_STAT("rx_packets", rx_packets), > + HNS3_NETDEV_STAT("tx_packets", tx_packets), > + HNS3_NETDEV_STAT("rx_bytes", rx_bytes), > + HNS3_NETDEV_STAT("tx_bytes", tx_bytes), > + HNS3_NETDEV_STAT("rx_errors", rx_errors), > + HNS3_NETDEV_STAT("tx_errors", tx_errors), > + HNS3_NETDEV_STAT("rx_dropped", rx_dropped), > + HNS3_NETDEV_STAT("tx_dropped", tx_dropped), > + HNS3_NETDEV_STAT("multicast", multicast), > + HNS3_NETDEV_STAT("collisions", collisions), > + > + /* detailed Rx errors */ Do not put network statistics in ethtool statistics. This is redundant and unnecessary. Yes some other drivers may do it but it is not best practice.