Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbdGWXyG (ORCPT ); Sun, 23 Jul 2017 19:54:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39438 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850AbdGWXxR (ORCPT ); Sun, 23 Jul 2017 19:53:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9EF4646214 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bhe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9EF4646214 Date: Mon, 24 Jul 2017 07:53:13 +0800 From: Baoquan He To: kbuild test robot Cc: kbuild-all@01.org, jroedel@suse.de, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Message-ID: <20170723235313.GB24530@x1> References: <1500627551-12930-12-git-send-email-bhe@redhat.com> <201707240618.mJ6b2eHv%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201707240618.mJ6b2eHv%fengguang.wu@intel.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sun, 23 Jul 2017 23:53:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2557 Lines: 68 On 07/24/17 at 06:33am, kbuild test robot wrote: > Hi Baoquan, > > [auto build test WARNING on iommu/next] > [also build test WARNING on v4.13-rc1] > [cannot apply to next-20170721] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Baoquan-He/Fix-the-on-flight-DMA-issue-on-system-with-amd-iommu/20170724-060048 > base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next > config: x86_64-randconfig-x005-201730 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > Note: it may well be a FALSE warning. FWIW you are at least aware of it now. > http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings > > All warnings (new ones prefixed by >>): > > drivers//iommu/amd_iommu_v2.c: In function 'ppr_notifier': > >> drivers//iommu/amd_iommu_v2.c:566:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] > int ret; > ^~~ > > vim +/ret +566 drivers//iommu/amd_iommu_v2.c Thanks, it should return NOTIFY_DONE anyway when ppr faults is handled in kdump kernel since the GCR3 table root pointer has been made NULL intentionally. I will add this into patch 11/13 when repost need be done. >From 742d8a51d8832e12884800840c4ebe802767d808 Mon Sep 17 00:00:00 2001 From: Baoquan He Date: Mon, 24 Jul 2017 07:48:10 +0800 Subject: [PATCH] iommu/amd: The ppr faults handled in kdump kernel should return NOTIFY_DONE Signed-off-by: Baoquan He --- drivers/iommu/amd_iommu_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c index 0245d414a7b3..e705fac89cb4 100644 --- a/drivers/iommu/amd_iommu_v2.c +++ b/drivers/iommu/amd_iommu_v2.c @@ -578,6 +578,7 @@ static int ppr_notifier(struct notifier_block *nb, unsigned long e, void *data) dev_data = get_dev_data(&pdev->dev); /* In kdump kernel pci dev is not initialized yet -> send INVALID */ + ret = NOTIFY_DONE; if (translation_pre_enabled(amd_iommu_rlookup_table[devid]) && dev_data->defer_attach) { amd_iommu_complete_ppr(pdev, iommu_fault->pasid, @@ -585,7 +586,6 @@ static int ppr_notifier(struct notifier_block *nb, unsigned long e, void *data) goto out; } - ret = NOTIFY_DONE; dev_state = get_device_state(iommu_fault->device_id); if (dev_state == NULL) goto out; -- 2.5.5