Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752406AbdGXBwM (ORCPT <rfc822;w@1wt.eu>);
        Sun, 23 Jul 2017 21:52:12 -0400
Received: from mail-pg0-f67.google.com ([74.125.83.67]:38382 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751782AbdGXBwC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 23 Jul 2017 21:52:02 -0400
Subject: Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period
 option showing number of samples
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
        Milian Wolff <milian.wolff@kdab.com>, Jiri Olsa <jolsa@redhat.com>
References: <1500500215-16646-1-git-send-email-treeze.taeung@gmail.com>
 <20170720191934.GD4134@kernel.org>
 <51c3c55a-d43d-427f-53fb-56b3ab275dd9@gmail.com>
 <20170721112420.GE4134@kernel.org>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <f8fa9e2d-f55f-512c-4637-eefc4dd646c9@gmail.com>
Date: Mon, 24 Jul 2017 10:51:58 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170721112420.GE4134@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1859
Lines: 54

Hi Arnaldo,

Sorry, I'm too late.

On 07/21/2017 08:24 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu:
>> On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote:
>>> Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu:
>>>> Currently the --show-total-period option of perf-annotate
>>>> is different from perf-report's.
> 
>>>> For example, perf-report ordinarily shows period and number of samples.
> 
>>>>    # Overhead       Samples        Period  Command  Shared Object   Symbol
>>>>         9.83%           102      84813704  test     test            [.] knapsack
> 
>>> But this is not what this patch does, it is still doing too many things,
>>> it should first add sample to those function signatures, leaving the
>>> "meat" to a followup patch, where we will not be distracted with
>>> infrastructure needed to do what you describe in the changelog.
> 
>>> I'm doing it here this time, please look at the result, later.
>   
>> ok, I'm waiting for it.
>> And if you give me some sketchy code, that's fine.
>> If you do, I'll remake this patch based on the result. :)
> 
> Take a look at the acme/tmp_perf/core, that is where I got yesterday.
> 
> - Arnaldo
> 

I fetched all branch of your repository, but it don't seem to be pushed.

$ git remote get-url acme
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git

$ git branch -a | grep acme | grep tmp | grep core
   remotes/acme/tmp.perf/core
   remotes/acme/tmp_perf.core

$ git show tmp.perf/core | head -3
commit 4827c52cd001e208704ab733a389c96ae2e70e5b
Author: Andi Kleen <ak@linux.intel.com>
Date:   Fri Jul 21 12:25:57 2017 -0700

$ git show tmp_perf.core | head -3
commit 3331778eb08a50cec959da933c040bd7fbdde396
Author: Adrian Hunter <adrian.hunter@intel.com>
Date:   Thu Jul 31 09:00:56 2014 +0300


Thanks,
Taeung