Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbdGXEw3 (ORCPT ); Mon, 24 Jul 2017 00:52:29 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:25168 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbdGXEwR (ORCPT ); Mon, 24 Jul 2017 00:52:17 -0400 X-AuditID: b6c32a4a-f79896d000000f29-51-59757cff2873 Subject: Re: [Patch v5 06/12] [media] v4l2-ioctl: add HEVC format description From: Smitha T Murthy To: Hans Verkuil Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, a.hajda@samsung.com, mchehab@kernel.org, pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com In-Reply-To: Date: Mon, 24 Jul 2017 09:58:45 +0530 Message-ID: <1500870525.16819.1817.camel@smitha-fedora> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPKsWRmVeSWpSXmKPExsWy7bCmpu7/mtJIg80LuC1urTvHanFq8jMm iyNrrzJZzDzRzmpx/vwGdouzTW/YLTY9vsZqcXnXHDaLng1bWS3WHrnLbrFs0x8mi0Vbv7Bb HH7TzurA67FpVSebx+Yl9R59W1YxenzeJOdx5Ugju8epr5/ZA9iiuGxSUnMyy1KL9O0SuDI2 7v3BWrCJq2L3+jbmBsapHF2MnBwSAiYSvR8WM0HYYhIX7q1n62Lk4hAS2M0osfLKaVYI5xOj xPa99xnhnG/TnrB0MXKAte/9agHSLSSwk1Hi620DCPsto0TLVDsQW1jAX+Lt7HUsIDabgI7E t/en2UBsEQFVide7fjGDzGQW2MYkcfnaZ7AzOAVsJV5caGAFsVmAilbvuARm8wqYS2xZeYQV ZC+vgKDE3x3CEFdrS6xrOAM2n1lAXmL72zlgMyUEutklml5eZ4YocpE4dGMhG4QtLPHq+BZ2 CFtK4mV/G5RdLrHnz08WiOYGRom5xxsZIRL2EgeuzAF7mFlAU2L9Ln2IsK3E9ylXGCEW80n0 /n4CDUYliUVnTrBDwodXoqNNCCLsIfHk3GQ2iLCjxLkG3gmMirMQnpmF5IFZCKsWMDKvYpRM LSjOTU8tNi0wykst1ytOzC0uzUvXS87P3cQITlZaXjsYl53zOcQowMGoxMMbIVoaKcSaWFZc mXuIUYKDWUmEd0ERUIg3JbGyKrUoP76oNCe1+BCjNAeLkjiv2o5rEUIC6YklqdmpqQWpRTBZ Jg5OqQbG6SbqT2U45NuEXyQsuDfrzs/fC/MeJ7x7mbnXWZZ7948T2wP4l9ziybf0iVXcwqD9 puu2plFYgE1521NltyKDchvJnKtdYSkCNbtyl5xmXX5gS94272aTZ5LJZUX7037b3dS5arSy 4cdvSZ+UovPm19OOpOs3J8gdD/yUH9zZ3v94019/tUIlluKMREMt5qLiRACOc8abUgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWy7bCSnO7hmtJIgx8b5SxurTvHanFq8jMm iyNrrzJZzDzRzmpx/vwGdouzTW/YLTY9vsZqcXnXHDaLng1bWS3WHrnLbrFs0x8mi0Vbv7Bb HH7TzurA67FpVSebx+Yl9R59W1YxenzeJOdx5Ugju8epr5/ZA9iiuGxSUnMyy1KL9O0SuDI2 7v3BWrCJq2L3+jbmBsapHF2MHBwSAiYSe79adDFyApliEhfurWfrYuTiEBLYzihx7+VXdoiE hMTK35MYIWxhiZX/nrNDFL1mlPi6ogmsSFjAX+Lt7HUsIDabgI7Et/en2UBsEQFVide7fjGD NDALrGeSaLn2C6yBU8BW4sWFBlYQW0igk0niwal4EJtZQFOidftvsBoWoObVOy6B1fAKmEts WXmEFeRqXgFBib87hCEO0pZY13CGBaJVXmL72znMExiFZiGZNAuhYxaSqgWMzKsYRVMLinPT c4sLDPWKE3OLS/PS9ZLzczcxguNKK3EH47oZ4YcYBTgYlXh4I0RLI4VYE8uKK3MPMUpwMCuJ 8C4oAgrxpiRWVqUW5ccXleakFh9ilOZgURLnvVW9IUJIID2xJDU7NbUgtQgmy8TBKdXAKPW0 MpH9n0vasgKPxfo6B7fxvfqvfawvW36ppPt+FUmLotrtEaV6p47dFE/eO89nQrNpmJPYjjAO j953N+4+2yorKNTdoBt/+eXSPMNbRTeCDhaoPLkU/PZjZculJZvjShR+zton+PnghR97erOk ln4IDbxTXxQo67Vjctua3Ruq5pqc8BVapsRSnJFoqMVcVJwIAOI0l/anAgAA X-CMS-MailID: 20170724045214epcas5p440ca085657d7298f2863e8a1b3d07cdb X-Msg-Generator: CA X-Sender-IP: 182.195.40.13 X-Local-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItRkRTIFNXG+yCvOyEsQ==?= =?UTF-8?B?7KCE7J6QG0xlYWQgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItRkRTIFNXG1NhbXN1bmcg?= =?UTF-8?B?RWxlY3Ryb25pY3MbTGVhZCBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= Content-Type: text/plain; charset="utf-8" X-MTR: 20170724045214epcas5p440ca085657d7298f2863e8a1b3d07cdb CMS-TYPE: 105P X-CMS-RootMailID: 20170619052507epcas1p406fa9f6d84baa9c11050b1998021788a X-RootMTR: 20170619052507epcas1p406fa9f6d84baa9c11050b1998021788a References: <1497849055-26583-1-git-send-email-smitha.t@samsung.com> <1497849055-26583-7-git-send-email-smitha.t@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 42 On Thu, 2017-07-20 at 15:07 +0200, Hans Verkuil wrote: > On 19/06/17 07:10, Smitha T Murthy wrote: > > HEVC is a video coding format > > > > Signed-off-by: Smitha T Murthy > > --- > > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > > index e5a2187..4f6f8d9 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1257,6 +1257,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > > case V4L2_PIX_FMT_VC1_ANNEX_L: descr = "VC-1 (SMPTE 412M Annex L)"; break; > > case V4L2_PIX_FMT_VP8: descr = "VP8"; break; > > case V4L2_PIX_FMT_VP9: descr = "VP9"; break; > > + case V4L2_PIX_FMT_HEVC: descr = "HEVC"; break; > > Add a little comment at the end of the line: /* aka H.265 */ > > After that you can add my: > > Acked-by: Hans Verkuil > > Regards, > > Hans > Ok I will make the change. Thanks for the review. Regards, Smitha > > case V4L2_PIX_FMT_CPIA1: descr = "GSPCA CPiA YUV"; break; > > case V4L2_PIX_FMT_WNVA: descr = "WNVA"; break; > > case V4L2_PIX_FMT_SN9C10X: descr = "GSPCA SN9C10X"; break; > > > > >