Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752963AbdGXF5X (ORCPT ); Mon, 24 Jul 2017 01:57:23 -0400 Received: from mout.gmx.net ([212.227.15.15]:57958 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbdGXF5O (ORCPT ); Mon, 24 Jul 2017 01:57:14 -0400 Subject: Re: [PATCH v1 1/2] remoteproc: dt: Provide bindings for iMX6SX/7D Remote Processor Controller driver To: Bjorn Andersson , Oleksij Rempel References: <20170710144220.31594-1-o.rempel@pengutronix.de> <20170710144220.31594-2-o.rempel@pengutronix.de> <20170710221408.GD1618@tuxbook> <91bfe236-0410-b26e-7ef6-73d14ebf120d@pengutronix.de> <20170718163814.GD20973@minitux> Cc: Oleksij Rempel , devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , Russell King , Shawn Guo , Fabio Estevam , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org From: Oleksij Rempel Message-ID: Date: Mon, 24 Jul 2017 07:56:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170718163814.GD20973@minitux> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WRxAqNGNBEr6BmCdTjFdvK85kEoRuPfHK" X-Provags-ID: V03:K0:k5yVeF4+I4XF+/lS/94QfmjRd6JhWJzv66INi+eH64LxnY+Zt/Q j5WrNkaNSoxUPx9SgeHs1g/wP2oCVwHvftQKgAHHelIfGA2Mxw52msK8hw3UI1j4gkcEJQu +wPMZITO/R6FkAavTTkidQMWQIfIHuv5TXo6FeQQ7ZPk9n1eib93cKC/6i4OUAUbsN8BwwA XJFJiM+j8Ze/lGZVJjZDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:eK1BjpFGptc=:15D6TeJ19m2RVw0iJlwKKQ 7JB3Uy7WAW862jMTGcSA8EeVj1kufSr1UehOg8xXDyoRoHVDlmqaQAmA0BlS13uGbB3Eoys3p j+qUwP1W5kmZQtrx+zF9QrxVuCEzFxvtHVpYsNjR5Tg1PIfcU/moWBtkt7+1Sa0gZYbBm09/D dSinEL+x/ux2p+s4BINXWSBaRrKiZvrlssrCbrrJU3veWY/AaI1XXQzPHKQ2kqhfOdiVror/N a+MZPmBgdh+C9ITQrkgSssyJ4Xa4O0Q+ZvDmNC5EpZ7Q5NLJ0BXC7GTv69ognoPi+iNx2AClz aLp9/5+TGhnxOoIqKvtxaG+XuYORetaR/GV3UiuylUPIJi2+/2mzhGb2M1r+slqywPv4zuI5P gM9yk9o9+oyu6k8TOFaClMkJjNYhuRMd5NDOjgYnDAh6hGlGbFBcx7FDJkRVk8mAaselDsz3Q s37ypT9zL0JJ+M6wo2Yr5N7z6Q7F2nn3bkYj6d6/H9BWyzK6KR/vvRkL6XVUKp8aoltgXI67T LTwXUeiATd52+iNMpISUTn2FZ2hPjj8URPLvJ36s84Jx9yeGIrYpPgiEjQTUVjsPDS7xrndS9 HjKE8Dx2kIuHoBqdPtEXesZkrJg9RlgLGAkQ71UCeyrEjlAKosuPVPOaySiLT1NemuFyux9dW F65+i7U8nbUYmZ/Aa0mje3QYLAr0JLs2qEP6vPOiFG6Z2VMJdUvYESDp8UeDq49ysW5AAvTqv S01p59kKxGna4AT8faRBolUJ83M6e7nV8SYQX9InYLeqCT3KgYdadWzbDYPghdNpWKvJDOYwb nNQ33NDM2efs6wVM4e7FozlIMO1Ww== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5657 Lines: 169 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WRxAqNGNBEr6BmCdTjFdvK85kEoRuPfHK Content-Type: multipart/mixed; boundary="XceOc38Mqw0f5jFgrIuq3UwDmviGi4voM"; protected-headers="v1" From: Oleksij Rempel To: Bjorn Andersson , Oleksij Rempel Cc: Oleksij Rempel , devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , Russell King , Shawn Guo , Fabio Estevam , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org Message-ID: Subject: Re: [PATCH v1 1/2] remoteproc: dt: Provide bindings for iMX6SX/7D Remote Processor Controller driver References: <20170710144220.31594-1-o.rempel@pengutronix.de> <20170710144220.31594-2-o.rempel@pengutronix.de> <20170710221408.GD1618@tuxbook> <91bfe236-0410-b26e-7ef6-73d14ebf120d@pengutronix.de> <20170718163814.GD20973@minitux> In-Reply-To: <20170718163814.GD20973@minitux> --XceOc38Mqw0f5jFgrIuq3UwDmviGi4voM Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 18.07.2017 um 18:38 schrieb Bjorn Andersson: > On Tue 18 Jul 01:45 PDT 2017, Oleksij Rempel wrote: >=20 >> Hallo Bjorn, >> >> On 11.07.2017 00:14, Bjorn Andersson wrote: >>> On Mon 10 Jul 07:42 PDT 2017, Oleksij Rempel wrote: >>> >>>> Signed-off-by: Oleksij Rempel >>>> --- >>>> .../devicetree/bindings/remoteproc/imx-rproc.txt | 44 +++++++++++= +++++++++++ >>>> 1 file changed, 44 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/imx= -rproc.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/imx-rproc.= txt b/Documentation/devicetree/bindings/remoteproc/imx-rproc.txt >>>> new file mode 100644 >>>> index 000000000000..e7c61993e1b8 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/remoteproc/imx-rproc.txt >>>> @@ -0,0 +1,44 @@ >>>> +NXP iMX6SX/iMX7D Co-Processor Bindings >>>> +---------------------------------------- >>>> + >>>> +This binding provides support for ARM Cortex M4 Co-processor found = on some >>>> +NXP iMX SoCs. >>>> + >>>> +Required properties: >>>> +- compatible Should be one of: >>>> + "fsl,imx7d-rproc" >>>> + "fsl,imx6sx-rproc" >>>> +- clocks Clock for co-processor (See: ../clock/clock-bindings.txt)= >>>> +- syscfg Phandle to syscon block which provide access to >>> >>> This is called "syscon" in the code and the example. >> >> done. >> >>>> + System Reset Controller >>>> + >>>> +Optional properties: >>>> +- reg: Should contain the address ranges for some of internal >>>> + memory regions. >>> >>> Something less hand-wavy, like: "Should list the memory regions for t= he >>> remoteproc" >>> >>>> +- reg-names: Contains the corresponding names for the memory >>>> + regions. These should be named "ddr", "ocram", "ocram-s", >>>> + "ocram-epdc" or "ocram-pxp". >>> >>> Make this comment define which memory regions are required for each o= f >>> the systems. >> >> done. >> >>>> +Fallowing memory ranges are expected: >>>> +- For "fsl,imx7d-rproc" >>>> + <0x00900000 0x00020000> - "ocram" >>>> + <0x00920000 0x00020000> - "ocram-epdc" >>>> + <0x00940000 0x00008000> - "ocram-pxp" >>>> + <0x80000000 0x0FFF0000> - "ddr" (code area) >>>> + <0x80000000 0x60000000> - "ddr" (data area) >>> >>> There's no reason to list the actual regions in the binding >>> document. Just list the requires regions for each system. >>> >>>> +- For "fsl,imx6sx-rproc" >>>> + <0x008F8000 0x00004000> - "ocram-s" >>>> + <0x80000000 0x0FFF8000> - "ddr" (code area) >>>> + <0x80000000 0x60000000> - "ddr" (data area) >>>> + >>>> +Note: the "ddr" code and data ranges are overlapping. Code area is = smaller >>>> +than data area. So this range should be carefully chosen according= to your >>>> +system and application requirements. >>>> + >>> >>> This is a source of future issues as this indicates that I should hav= e >>> reg-names list "ddr" twice. >> >> Then I will name it: >> "ddri" (incstruction/code area), >> "ddrd" (data area) >> >> unless there are other suggestions. >> >=20 > But are you saying that it's correct that these two memory regions > should overlap? Yes, from Cortex-m4 the same memory regions are aliased to different address ranges to provide different cache optimizations. =46rom Cortex-A7 side - not. But on this side we don't care about meaning= of it, it is just some memory region. >>> Also, as you warn about the user needing to pick the values for "ddr"= , >>> does that mean that it's a carveout of System RAM? >> >> Yes, it is a part of System RAM. >> >=20 > Then there will be an associated reserved-memory region for the > region(s), you should add a label to this and use "memory-region" to ge= t > hold of the addresses instead. Ok. Should only system memory region be assigned over reserved-memory or all of named regions? --=20 Regards, Oleksij --XceOc38Mqw0f5jFgrIuq3UwDmviGi4voM-- --WRxAqNGNBEr6BmCdTjFdvK85kEoRuPfHK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iF4EAREIAAYFAll1jAQACgkQHwImuRkmbWncgAD9HyoFETBlJx0WvK34jxiDZWO8 msN6x3BcOxVNkn0uZ1QA/iZHURQsl8bq+AIdQ+X5G65v4xjdbEkDBT6V2xt8Rx0d =VB6v -----END PGP SIGNATURE----- --WRxAqNGNBEr6BmCdTjFdvK85kEoRuPfHK--