Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752943AbdGXHti (ORCPT ); Mon, 24 Jul 2017 03:49:38 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41933 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752828AbdGXHtL (ORCPT ); Mon, 24 Jul 2017 03:49:11 -0400 Date: Mon, 24 Jul 2017 10:48:58 +0300 From: Dan Carpenter To: Marcus Wolf Cc: gregkh@linuxfoundation.org, Derek Robson , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: pi433: - style fix, space before tabs Message-ID: <20170724074858.q7hsqlk5et65kegl@mwanda> References: <20170722035105.27750-1-robsonde@gmail.com> <403797028.18523.1500713304938@ox.hosteurope.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <403797028.18523.1500713304938@ox.hosteurope.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 22 On Sat, Jul 22, 2017 at 10:48:24AM +0200, Marcus Wolf wrote: > Reviewed-by: Marcus Wolf > > >From my point of view, the rearrangement of the block of SET_CHECKED reduces the > readability a lot. I like same stuff to be aligned (all brakets below each other > as a column, all spi->dev below each other and so on) But if it is necessary to > fullfill the rules, we have to do it the new way. It's not necessary. The rule is just complaining about this: SET_CHECKED(rf69_set_bandwidth (dev->spi, rx_cfg->bw_mantisse, rx_cfg->bw_exponent)); ^ There is a space after the 'h' character. The old code has "[space][tab][tab][space](dev->spi,..." it should be: "[tab][tab][space](dev->spi, ..." Also the rules are there to improve readability. Sometimes they're debatable but if they make readability worse, then we can ignore the rules. regards, dan carpenter