Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbdGXHxn (ORCPT ); Mon, 24 Jul 2017 03:53:43 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:24018 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdGXHxg (ORCPT ); Mon, 24 Jul 2017 03:53:36 -0400 Date: Mon, 24 Jul 2017 10:53:23 +0300 From: Dan Carpenter To: Derek Robson Cc: gregkh@linuxfoundation.org, linux@Wolf-Entwicklungen.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line Message-ID: <20170724075323.gzjywkjc66y3a5kl@mwanda> References: <20170722035121.27796-1-robsonde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170722035121.27796-1-robsonde@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 36 On Sat, Jul 22, 2017 at 03:51:21PM +1200, Derek Robson wrote: > Fixed checkpatch errors of "please, no spaces at the start of a line" > > Signed-off-by: Derek Robson > --- > drivers/staging/pi433/rf69.c | 4 +- > drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++------------------- > 2 files changed, 105 insertions(+), 105 deletions(-) > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index d931437f0b6a..f450bbf3fbbc 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mant > // check value for mantisse and exponent > if (exponent > 7) INVALID_PARAM; > if ( (mantisse!=mantisse16) && > - (mantisse!=mantisse20) && > - (mantisse!=mantisse24) ) INVALID_PARAM; > + (mantisse!=mantisse20) && > + (mantisse!=mantisse24) ) INVALID_PARAM; > This is wrong. It should be aligned like this: if (exponent > 7) INVALID_PARAM; if (mantisse != mantisse16 && mantisse != mantisse20 && mantisse != mantisse24) INVALID_PARAM; regards, dan carpenter