Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbdGXIm1 (ORCPT ); Mon, 24 Jul 2017 04:42:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59220 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbdGXImR (ORCPT ); Mon, 24 Jul 2017 04:42:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5E7986086D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org Subject: Re: [PATCH] usb: dwc3: Support the dwc3 host suspend/resume To: Baolin Wang Cc: Felipe Balbi , Greg KH , USB , LKML , Linaro Kernel Mailman List , Mark Brown References: <2086ce508be1c1d75d47c892a5be9593b12fa6f3.1500619870.git.baolin.wang@linaro.org> <0f1345b4-292c-1881-8bba-d81293b9ace8@codeaurora.org> <50e53fba-1f69-6ba1-cc9d-8cb02a3e0468@codeaurora.org> From: Manu Gautam Message-ID: Date: Mon, 24 Jul 2017 14:12:11 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 27 Hi Baolin, On 7/24/2017 11:26 AM, Baolin Wang wrote: >>>> Other than what I pushed in my patch - >>>> ("usb: dwc3: Don't reinitialize core during host bus-suspend/resume") >>>> Just performing pm_request_resume or handling same in dwc3 glue >>>> driver should be sufficient. >>> Yes. >>> >>>> Also, what is trigger for runtime_resume for your platform? >>> In our platform glue layer, we have extcon events to notify there are >>> devices connected, then gule layer will resume dwc3 device. >>> >> IMO you can just perform resume of &dwc->xhci->dev instead of resuming dwc3. >> Since, dwc3 is parent of xhci that will trigger resume of dwc3 as well. > I am not sure this is good enough but it seems can solve some > problems, then we do not need resume/suspend host in dwc3 core. In that case can we proceed with this patch: [1] https://www.spinics.net/lists/linux-usb/msg158682.html For your platform you can pick this patch and resume dwc->xhci->dev resume from your glue driver. Do you have any other concerns?