Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755519AbdGXM1h (ORCPT ); Mon, 24 Jul 2017 08:27:37 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:35750 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753453AbdGXM13 (ORCPT ); Mon, 24 Jul 2017 08:27:29 -0400 Subject: Re: [PATCH] ARM64: meson-gxl: disable broken eee From: Neil Armstrong To: Joseph Kogut , Kevin Hilman Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , robh+dt@kernel.org, carlo@caione.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20170707013257.18250-1-joseph.kogut@gmail.com> <7ho9scsdbp.fsf@baylibre.com> Organization: Baylibre Message-ID: <7519c9ee-54f0-d5fb-1683-11d6e24f0822@baylibre.com> Date: Mon, 24 Jul 2017 14:26:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3175 Lines: 82 On 07/24/2017 02:06 PM, Neil Armstrong wrote: > On 07/23/2017 07:03 PM, Joseph Kogut wrote: >> Hi Kevin, >> >> I tested on a P212 reference board, which is currently the only GXL >> based board I have. >> >> Before applying the patch, high activity on the ethernet interface >> would cause the link to break, requiring the interface to be brought >> down and back up before it would work again. After applying the patch, >> I could not get the link to break with any transfers. >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > > Hi Joseph, > > [please keep the history of the conversation when replying] > > Is it a original P212 board, or a board based on the P212 ref design ? > > I'm currently testing the v4.13-rc2 on the official P212 board we received from Amlogic > and using iperf3 in both directions, I have an issue after a few minutes running iperf3 with : > > # while true ; do iperf3 -c 192.168.1.21 ; iperf3 -c 192.168.1.21 -R ; done > > That cycles between the two iperf directions. > > After a few minutes, it stalls with : > > Connecting to host 192.168.1.21, port 5201 > [ 4] local 192.168.1.183 port 51286 connected to 192.168.1.21 port 5201 > [ ID] Interval Transfer Bandwidth Retr Cwnd > [ 4] 0.00-1.00 sec 1.64 MBytes 13.7 Mbits/sec 2 1.41 KBytes > [ 4] 1.00-2.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes > [ 4] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > [ 4] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes > [ 4] 4.00-5.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > [ 4] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > [ 4] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes > [ 4] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > [ 4] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes > > > And then, after: > # ifconfig eth0 down > # ifconfig eth0 up > > It cycles between : > [ 1483.009919] meson8b-dwmac c9410000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx > [ 1487.105725] meson8b-dwmac c9410000.ethernet eth0: Link is Down > [ 1490.177943] meson8b-dwmac c9410000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx > [ 1494.273713] meson8b-dwmac c9410000.ethernet eth0: Link is Down > > and so on. > > And this patch does not fix this at all. > > It seems to be more a PHY driver issue here. > > Could you share the results with the same command ? > > Neil > I forgot to precise, this issue occurs when the "GXL PHY driver" is disabled, only relying on the Generic PHY Driver. [ 630.767538] Generic PHY 0.e40908ff:08: attached PHY driver [Generic PHY] (mii_bus:phy_addr=0.e40908ff:08, irq=-1) When the PHY driver is loaded the issue disappears, with and without your patch. [ 25.355620] Meson GXL Internal PHY 0.e40908ff:08: attached PHY driver [Meson GXL Internal PHY] (mii_bus:phy_addr=0.e40908ff:08, irq=-1) Could you please check the PHY Driver is loaded ? Thanks, Neil