Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755683AbdGXMuD (ORCPT ); Mon, 24 Jul 2017 08:50:03 -0400 Received: from mail-ua0-f176.google.com ([209.85.217.176]:37474 "EHLO mail-ua0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbdGXMt5 (ORCPT ); Mon, 24 Jul 2017 08:49:57 -0400 MIME-Version: 1.0 In-Reply-To: <20170724085005.22101-2-gary.bisson@boundarydevices.com> References: <20170724085005.22101-1-gary.bisson@boundarydevices.com> <20170724085005.22101-2-gary.bisson@boundarydevices.com> From: Fabio Estevam Date: Mon, 24 Jul 2017 09:49:56 -0300 Message-ID: Subject: Re: [PATCH 1/2] ARM: dts: imx6qdl-sabrelite: fix USB PHY reset To: Gary Bisson Cc: "devicetree@vger.kernel.org" , linux-kernel , "robh+dt@kernel.org" , Sascha Hauer , Fabio Estevam , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 22 Hi Gary, On Mon, Jul 24, 2017 at 5:50 AM, Gary Bisson wrote: > + > + reg_usb_h1_vbus: regulator@7 { > + compatible = "regulator-fixed"; > + reg = <7>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usbh1>; > + regulator-name = "usb_h1_vbus"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-always-on; As this regulator is controlled via GPIO I believe you should remove the ' regulator-always-on' property. Same applies to 2/2/