Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755788AbdGXMvc convert rfc822-to-8bit (ORCPT ); Mon, 24 Jul 2017 08:51:32 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:8109 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbdGXMv0 (ORCPT ); Mon, 24 Jul 2017 08:51:26 -0400 From: Aleksandar Markovic To: James Hogan , Aleksandar Markovic CC: "linux-mips@linux-mips.org" , Miodrag Dinic , Goran Ferenc , "Douglas Leung" , "linux-kernel@vger.kernel.org" , Paul Burton , "Petar Jovanovic" , Raghu Gandham , Ralf Baechle Subject: RE: [PATCH v3 08/16] MIPS: math-emu: .: Fix cases of input values with opposite signs Thread-Topic: [PATCH v3 08/16] MIPS: math-emu: .: Fix cases of input values with opposite signs Thread-Index: AQHTAitycG1MTSVZqUCSgLsMgSkGz6Je4MuAgAQRkpM= Date: Mon, 24 Jul 2017 12:51:20 +0000 Message-ID: References: <1500646206-2436-1-git-send-email-aleksandar.markovic@rt-rk.com> <1500646206-2436-9-git-send-email-aleksandar.markovic@rt-rk.com>,<20170721154201.GM6973@jhogan-linux.le.imgtec.org> In-Reply-To: <20170721154201.GM6973@jhogan-linux.le.imgtec.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [82.117.201.26] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 29 > > ________________________________________ > From: James Hogan > Sent: Friday, July 21, 2017 8:42 AM > To: Aleksandar Markovic > Cc: linux-mips@linux-mips.org; Aleksandar Markovic; Miodrag Dinic; Goran Ferenc; Douglas Leung; linux-kernel@vger.kernel.org; Paul Burton; Petar Jovanovic; Raghu Gandham; Ralf Baechle > Subject: Re: [PATCH v3 08/16] MIPS: math-emu: .: Fix cases of input values with opposite signs > > On Fri, Jul 21, 2017 at 04:09:06PM +0200, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > > > Fix the value returned by ., if inputs are normal fp > > numbers of the same absolute value, but opposite signs. > > > > The relevant example: > > > > MAXA.S fd,fs,ft: > > If fs contains -3, and ft contains +3, fd is going to contain +3 > > (without this patch, it used to contain -3). > > I think its worth mentioning also that for MINA.*, it returns the > negative one when the absolute values are equal (The phrase "For equal > absolute values, returns the smallest positive argument" in the manual > is a bit ambiguous IMO, so I ended up checking what I6500 did). I am going to slightly rephrase the commit messege to address this. Regards, Aleksandar