Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755794AbdGXMxG (ORCPT ); Mon, 24 Jul 2017 08:53:06 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37414 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbdGXMw6 (ORCPT ); Mon, 24 Jul 2017 08:52:58 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170724085005.22101-1-gary.bisson@boundarydevices.com> <20170724085005.22101-2-gary.bisson@boundarydevices.com> From: Gary Bisson Date: Mon, 24 Jul 2017 14:52:57 +0200 Message-ID: Subject: Re: [PATCH 1/2] ARM: dts: imx6qdl-sabrelite: fix USB PHY reset To: Fabio Estevam Cc: "devicetree@vger.kernel.org" , linux-kernel , "robh+dt@kernel.org" , Sascha Hauer , Fabio Estevam , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1005 Lines: 31 Hi Fabio, On Mon, Jul 24, 2017 at 2:49 PM, Fabio Estevam wrote: > > Hi Gary, > > On Mon, Jul 24, 2017 at 5:50 AM, Gary Bisson > wrote: > > > + > > + reg_usb_h1_vbus: regulator@7 { > > + compatible = "regulator-fixed"; > > + reg = <7>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usbh1>; > > + regulator-name = "usb_h1_vbus"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + regulator-always-on; > > As this regulator is controlled via GPIO I believe you should remove > the ' regulator-always-on' property. > > Same applies to 2/2/ Good catch, I'll send a v2 right away. Thanks, Gary