DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E668F4A6E3
Subject: Re: [PATCH] KVM: nVMX: Fix exception injection
To: Jim Mattson <jmattson@google.com>, Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
References: <1496460115-12654-1-git-send-email-wanpeng.li@hotmail.com>
 <2ba5e53d-14f4-14a1-0084-a8b521a3ec3e@redhat.com>
 <CANRm+CxbPytrbMckLQO3_7PzezP=1Ty6ThjwRnpnq76riuH+Ww@mail.gmail.com>
 <CALMp9eQvwf5F9K5P4nOidHaKuS2CiTWOf09A3kNeLFfau=jpTQ@mail.gmail.com>
 <CANRm+Czgqv+V4gnapxMVdUEJ5-bqxhN3iD9h9HSy1-XTustEBQ@mail.gmail.com>
 <CALMp9eSO4iaksTkO5q=vhonD7JoWE5B5iJyEgC0Otx5CAdKMyQ@mail.gmail.com>
 <CANRm+Cx0Ppb74WCsR5Lvy0+zacT-2s7AYxG_V=exfE0n9ZUbOw@mail.gmail.com>
 <CALMp9eTBcUAD06=HoDzeb-T_bNgj-H=jSVwyk3doOVsCva9g1A@mail.gmail.com>
 <CANRm+CyaN+nTJOtT+3ORJQ+U-Sw9CzuyBWbjuSgS11aYD+3pfQ@mail.gmail.com>
 <CALMp9eThhFdCJ6GWqDyKF+9fb_gctJ2X+b3oTs42A3fuVt2y8Q@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <db87c838-c44d-15d9-55bf-c4d6831d825d@redhat.com>
Date: Mon, 24 Jul 2017 15:02:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CALMp9eThhFdCJ6GWqDyKF+9fb_gctJ2X+b3oTs42A3fuVt2y8Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 836
Lines: 21

On 23/07/2017 03:11, Jim Mattson wrote:
>>> In the situation you describe, the #PF causes a synthesized VM-exit
>>> from L2 to L1 directly, not indirectly. From the SDM:
>>>
>>>    An exception causes a VM exit directly if the bit corresponding to
>>> that exception is set in the exception bitmap.
>>>
>>> Hence, CR2 should not be set yet.
>>
>> Any idea how to synthesize exit qualification for page fault and debug
>> exception?
>
> I think the ancillary data for #DB and #PF should be added to
> kvm_queued_exception and plumbed through to where it's needed. Vector
> number and error code are not sufficient to describe a #DB or #PF.

It's more complicated than that, because you'd have to copy it out to
userspace in KVM_GET_VCPU_EVENTS.  But I agree it's the way to go: CR2
and DR6 should be only by inject_pending_event.

Paolo