Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932407AbdGXO4H (ORCPT ); Mon, 24 Jul 2017 10:56:07 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:32988 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932307AbdGXOzN (ORCPT ); Mon, 24 Jul 2017 10:55:13 -0400 From: Thierry Reding To: Linus Walleij Cc: Jonathan Hunter , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] gpio: tegra: Prefer kcalloc() over kzalloc() with multiplies Date: Mon, 24 Jul 2017 16:55:06 +0200 Message-Id: <20170724145508.7388-2-thierry.reding@gmail.com> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170724145508.7388-1-thierry.reding@gmail.com> References: <20170724145508.7388-1-thierry.reding@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 29 From: Thierry Reding Rather than manually compute the size of an array, pass the number and element size to kcalloc(). Signed-off-by: Thierry Reding --- drivers/gpio/gpio-tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 63ee221f9be9..1d4df290d7ab 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -621,10 +621,10 @@ static int tegra_gpio_probe(struct platform_device *pdev) if (tgi->soc->debounce_supported) tgi->gc.set_config = tegra_gpio_set_config; - tgi->bank_info = devm_kzalloc(&pdev->dev, tgi->bank_count * + tgi->bank_info = devm_kcalloc(&pdev->dev, tgi->bank_count, sizeof(*tgi->bank_info), GFP_KERNEL); if (!tgi->bank_info) - return -ENODEV; + return -ENOMEM; tgi->irq_domain = irq_domain_add_linear(pdev->dev.of_node, tgi->gc.ngpio, -- 2.13.3