Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756590AbdGXRhz (ORCPT ); Mon, 24 Jul 2017 13:37:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:51610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754259AbdGXRh3 (ORCPT ); Mon, 24 Jul 2017 13:37:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C32AC22CA0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 24 Jul 2017 14:37:25 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim , Milian Wolff , Jiri Olsa Subject: Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples Message-ID: <20170724173725.GT4134@kernel.org> References: <1500500215-16646-1-git-send-email-treeze.taeung@gmail.com> <20170720191934.GD4134@kernel.org> <51c3c55a-d43d-427f-53fb-56b3ab275dd9@gmail.com> <20170721112420.GE4134@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3330 Lines: 77 Em Mon, Jul 24, 2017 at 10:51:58AM +0900, Taeung Song escreveu: > Hi Arnaldo, > > Sorry, I'm too late. > > On 07/21/2017 08:24 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu: > > > On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote: > > > > Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu: > > > > > Currently the --show-total-period option of perf-annotate > > > > > is different from perf-report's. > > > > > > > For example, perf-report ordinarily shows period and number of samples. > > > > > > > # Overhead Samples Period Command Shared Object Symbol > > > > > 9.83% 102 84813704 test test [.] knapsack > > > > > > But this is not what this patch does, it is still doing too many things, > > > > it should first add sample to those function signatures, leaving the > > > > "meat" to a followup patch, where we will not be distracted with > > > > infrastructure needed to do what you describe in the changelog. > > > > > > I'm doing it here this time, please look at the result, later. > > > ok, I'm waiting for it. > > > And if you give me some sketchy code, that's fine. > > > If you do, I'll remake this patch based on the result. :) > > > > Take a look at the acme/tmp_perf/core, that is where I got yesterday. > > > > - Arnaldo > > > > I fetched all branch of your repository, but it don't seem to be pushed. > > $ git remote get-url acme > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > $ git branch -a | grep acme | grep tmp | grep core > remotes/acme/tmp.perf/core > remotes/acme/tmp_perf.core > > $ git show tmp.perf/core | head -3 > commit 4827c52cd001e208704ab733a389c96ae2e70e5b > Author: Andi Kleen > Date: Fri Jul 21 12:25:57 2017 -0700 The one above, look further down, from 896bccd3cb8d to 0321d0281cbb, there are some more missing, but the ones below should be ready for sending to Ingo, which I plan to do today. 4827c52cd001 perf jevents: Make build fail on JSON parse error 768750b250b4 perf top: Support lookup of symbols in other mount namespaces. bd09c1d5f473 perf stat: Use group read for event groups b9830d226aae perf evsel: Add read_counter() method e9c58e8b74b8 perf evsel: Add read_size method b1f952a065d6 perf evsel: Add verbose output for sys_perf_event_open fallback 1321cb6fb1ac perf jvmti: Fix linker error when libelf config is disabled 27cf8ae9ac36 perf annotate: Process tracing data in pipe mode 76dd07b982e0 perf tools: Add EXCLUDE_EXTLIBS and EXTRA_PERFLIBS to makefile f246e8b7f34e perf cgroup: Fix refcount usage 60cdc09e7d77 perf report: Fix kernel symbol adjustment for s390x 0321d0281cbb perf annotate stdio: Fix --show-total-period ecd5f9959d2c perf annotate: Do not overwrite sample->period 461c17f00f40 perf annotate: Store the sample period in each histogram bucket bab89f6aed7e perf hists: Pass perf_sample to __symbol__inc_addr_samples() 8158683da3d3 perf annotate: Rename 'sum' to 'nr_samples' in struct sym_hist 896bccd3cb8d perf annotate: Introduce struct sym_hist_entry > $ git show tmp_perf.core | head -3 > commit 3331778eb08a50cec959da933c040bd7fbdde396 > Author: Adrian Hunter > Date: Thu Jul 31 09:00:56 2014 +0300 > > > Thanks, > Taeung