Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932198AbdGXSWy (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Jul 2017 14:22:54 -0400
Received: from mail-pg0-f67.google.com ([74.125.83.67]:37749 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753515AbdGXSWp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jul 2017 14:22:45 -0400
Date: Mon, 24 Jul 2017 13:22:42 -0500
From: Rob Herring <robh@kernel.org>
To: sean.wang@mediatek.com
Cc: matthias.bgg@gmail.com, mark.rutland@arm.com, lgirdwood@gmail.com,
        broonie@kernel.org, jamesjj.liao@mediatek.com,
        henryc.chen@mediatek.com, devicetree@vger.kernel.org,
        linux-mediatek@lists.infradead.org, chen.zhong@mediatek.com,
        chenglin.xu@mediatek.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek
 MT6380 regulator
Message-ID: <20170724182242.ejrobnjks3ehprpw@rob-hp-laptop>
References: <cover.1500368529.git.sean.wang@mediatek.com>
 <fef9412087f3961e03b77c067e227a31860a1417.1500368529.git.sean.wang@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fef9412087f3961e03b77c067e227a31860a1417.1500368529.git.sean.wang@mediatek.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1481
Lines: 38

On Tue, Jul 18, 2017 at 05:49:22PM +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> add dt-binding document for MediaTek MT6380 PMIC
> 
> Signed-off-by: Chenglin Xu <chenglin.xu@mediatek.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
>  .../bindings/regulator/mt6380-regulator.txt        | 90 ++++++++++++++++++++++
>  1 file changed, 90 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> 
> diff --git a/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> new file mode 100644
> index 0000000..2a559f0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> @@ -0,0 +1,90 @@
> +MediaTek MT6380 Regulator Driver

Bindings don't describe drivers.

> +
> +All voltage regulators are defined as subnodes of the regulators node. A list

What's the regulators node a child of?

> +of regulators provided by this controller are defined as subnodes of the
> +PMIC's node. Each regulator is named according to its regulator type,
> +buck-<name> and ldo-<name>. The definition for each of these nodes is defined
> +using the standard binding for regulators at
> +Documentation/devicetree/bindings/regulator/regulator.txt.
> +
> +The valid names for regulators are:
> +BUCK:
> +  buck-core1, buck-vcore, buck-vrf
> +LDO:
> +  ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt