Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932244AbdGXS2j (ORCPT ); Mon, 24 Jul 2017 14:28:39 -0400 Received: from resqmta-po-05v.sys.comcast.net ([96.114.154.164]:36204 "EHLO resqmta-po-05v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755669AbdGXS2b (ORCPT ); Mon, 24 Jul 2017 14:28:31 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 0/3] kselftest build errors To: Naresh Kamboju , Fathi Boudra Cc: Marcin Nowakowski , SeongJae Park , linux-kselftest@vger.kernel.org, "linux-kernel@vger.kernel.org" , Shuah Khan , Shuah Khan References: <1498214246-1244-1-git-send-email-marcin.nowakowski@imgtec.com> <14a3d7aa-8038-470a-4166-7da6985241a2@kernel.org> From: Shuah Khan Message-ID: <03254abb-bb43-61fd-35f7-e4a7bc38daf7@kernel.org> Date: Mon, 24 Jul 2017 12:28:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfLf2xpL7Fy4H0wKvqGqUzTsLWzsahck9Sgedn1Ar6ceb/GEQoNbIyLKpPK+a7eVIdv8s8c4rHSOI8Ne5ClCXfxEIXCUxoUi32O7vErbBxML+5qujW5Kl tuVSVjgPYaEaAjibsDAO1/8WZxh0yBDFRxbbrzZLhHc5LtUfi2czDn3ghZcSUTj2VKGo3gy8Njeq0P4h0hxatdfHxAf9MlNvb6/9PTq966jqNNRU+byKR44w 5EuoQcoFbYANNqHpzvqd3rA7KepkLro+YyLkd3BeMN9ystQ6Qc9gye5ZLghG96xepZ45outcyuYBDkVrO+s90vl66ttyMXOhPPsFNCo04RgC4Tyc/qRSahc7 gw10/LZj5O1zUSTO3dtPH1CJCy4CxNCn9le750nnajjyfhXQsT4LmOqZr+ZfYV2nWq1Hf15yWDlXa392yLvr9nUz/XMKLA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2241 Lines: 67 On 07/12/2017 03:30 AM, Naresh Kamboju wrote: > Hi Fathi and Shuah, > > On 29 June 2017 at 14:07, Fathi Boudra wrote: >> On 28 June 2017 at 17:21, Shuah Khan wrote: >>> On 06/28/2017 02:30 AM, Fathi Boudra wrote: >>>> On 23 June 2017 at 22:44, Shuah Khan wrote: >>>>> On 06/23/2017 04:37 AM, Marcin Nowakowski wrote: >>>>>> This patch series fixes build errors observed when building net, memfd, gpio and intel_pstate tests >>>>>> >>>>>> Marcin Nowakowski (3): >>>>>> selftests/{net,memfd}: fix undefined references to external libraries >>>>>> selftests/gpio: fix build error >>>>>> selftests/intel_pstate: fix undefined reference when building >>>>>> >>>>>> tools/testing/selftests/gpio/Makefile | 2 +- >>>>>> tools/testing/selftests/intel_pstate/Makefile | 2 +- >>>>>> tools/testing/selftests/memfd/Makefile | 4 ++-- >>>>>> tools/testing/selftests/net/Makefile | 2 +- >>>>>> 4 files changed, 5 insertions(+), 5 deletions(-) >>>>>> >>>>> >>>>> Hi Marcin, >>>>> >>>>> SeongJae Park sent me fixes for the memfd/net/intel_pstate problems >>>>> last week. I pulled those in already. >>>>> >>>>> The gpio fix is something I need to look at closely to see if this is >>>>> the way to go. I will get back to you on that. >>>> >>>> Any updates on the gpio fix? I've tested it and it works for me. >>>> >>> >>> I haven't decided yet. >> >> another alternative is to use realpath: >> -GPIODIR := ../../../gpio >> +GPIODIR := $(realpath ../../../gpio) >> You are welcome to send a patch. >> btw, this commit: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=51c6bd7cbe0366b642d8ac90d98739c39ab091a9 >> should be reverted once the build error is addressed because they >> shouldn't have been there in the first place due to lack of trailing >> slash in the path. Yes. This was a temporary solution. thanks, -- Shuah > > The current status on linux-next is, > gpio-mockup-chardev.c building binary failed and shell script not able > to locate test binary, > gpio-mockup-chardev: No such file or directory > > Bug link, > https://bugs.linaro.org/show_bug.cgi?id=3122 > > - Naresh >> >>> thanks, >>> -- Shuah > >