Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756864AbdGXTQh (ORCPT ); Mon, 24 Jul 2017 15:16:37 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:37674 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756764AbdGXTNK (ORCPT ); Mon, 24 Jul 2017 15:13:10 -0400 Date: Mon, 24 Jul 2017 14:13:07 -0500 From: Rob Herring To: Abhishek Sahu Cc: dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, mark.rutland@arm.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, architt@codeaurora.org, sricharan@codeaurora.org Subject: Re: [PATCH v2 04/25] dt-bindings: qcom_nandc: change compatible string for EBI2 NANDC Message-ID: <20170724191307.pbgfnye5gsc4yso2@rob-hp-laptop> References: <1500464893-11352-1-git-send-email-absahu@codeaurora.org> <1500464893-11352-5-git-send-email-absahu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1500464893-11352-5-git-send-email-absahu@codeaurora.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 31 On Wed, Jul 19, 2017 at 05:17:52PM +0530, Abhishek Sahu wrote: > The current compatible string “qcom,ipq806x-nand" implies that > the driver is specific to IPQ806x. This driver can be used by > any chip which uses EBI2 NAND controller so changed the > compatible string to “qcom,ebi2-nandc” to give it more generic > name. > > Since there is no user for this driver currently in so > changing compatible string is safe. > > Signed-off-by: Abhishek Sahu > --- > Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > index 70dd511..4511918 100644 > --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > @@ -1,7 +1,9 @@ > * Qualcomm NAND controller > > Required properties: > -- compatible: should be "qcom,ipq806x-nand" > +- compatible: should be "qcom,ebi2-nandc" - EBI2 NAND which uses ADM > + DMA like IPQ8064. Compatible strings are supposed to be specific to the SoC. The old one wasn't quite and the new one moves in the wrong direction. Rob