Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932492AbdGXTUq (ORCPT ); Mon, 24 Jul 2017 15:20:46 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34214 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932484AbdGXTUa (ORCPT ); Mon, 24 Jul 2017 15:20:30 -0400 Date: Mon, 24 Jul 2017 21:20:26 +0200 From: Pavel Machek To: Julia Lawall Cc: Mark D Rustad , Tony Lindgren , keescook@chromium.org, kernel-janitors@vger.kernel.org, Lee Jones , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/11] mfd: Drop unnecessary static Message-ID: <20170724192026.GF32425@amd> References: <1500149266-32357-1-git-send-email-Julia.Lawall@lip6.fr> <1500149266-32357-8-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ExXT7PjY8AI4Hyfa" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 34 --ExXT7PjY8AI4Hyfa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > Drop static on a local variable, when the variable is initialized bef= ore > > > any possible use. Thus, the static has no benefit. Actually... it has possible other benefit -- saving stack space. I've used static for that purpose before. So ... careful with the automation. --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --ExXT7PjY8AI4Hyfa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAll2SHoACgkQMOfwapXb+vJ/BgCeJV9jNXiD3P7c9ZgXkWNaMmdy Wu0An0OKd8tWIa0ig042NowwGtXv727U =OuPP -----END PGP SIGNATURE----- --ExXT7PjY8AI4Hyfa--