Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754675AbdGXUJK (ORCPT ); Mon, 24 Jul 2017 16:09:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:46802 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753009AbdGXUGN (ORCPT ); Mon, 24 Jul 2017 16:06:13 -0400 Date: Mon, 24 Jul 2017 22:06:09 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Pavel Machek cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org, kernel list Subject: Re: v4.13-rc2: usb mouse stopped working? In-Reply-To: <20170724200056.GA3997@amd> Message-ID: References: <20170724200056.GA3997@amd> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1730 Lines: 42 On Mon, 24 Jul 2017, Pavel Machek wrote: > On thinkpad x220, USB mouse stopped working in v4.13-rc2. v4.12 was > ok, iirc. > > Now, USB mouse is so common hw that I may have something wrong in my > config...? But I did not change anything there. Well, your particular USB mouse requires an always-poll quirk, so it's not *that* common; therefore ... > In v4.9: > > [ 87.064408] input: Logitech USB Optical Mouse as > /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1/2-1.1.1/2-1.1.1.1/2-1.1.1.1:1.0/0003:046D:C05A.0005/input/input18 > [ 87.065951] hid-generic 0003:046D:C05A.0005: input,hidraw0: USB HID > v1.11 Mouse [Logitech USB Optical Mouse] on > usb-0000:00:1d.0-1.1.1.1/input0 > pavel@duo:~$ > > v4.13-rc2: > > [ 87.886810] usb 2-1.1.1.1: new low-speed USB device number 10 using ehci-pci > [ 88.019543] usb 2-1.1.1.1: New USB device found, idVendor=046d, idProduct=c05a > [ 88.019561] usb 2-1.1.1.1: New USB device strings: Mfr=1, Product=2, SerialNumber=0 > [ 88.019572] usb 2-1.1.1.1: Product: USB Optical Mouse > [ 88.019581] usb 2-1.1.1.1: Manufacturer: Logitech > [ 88.027276] input: Logitech USB Optical Mouse as /devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1/2-1.1.1/2-1.1.1.1/2-1.1.1.1:1.0/0003:046D:C05A.0005/input/input18 > [ 88.027825] hid-generic 0003:046D:C05A.0005: input,hidraw1: USB HID > v1.11 Mouse [Logitech USB Optical Mouse] on > usb-0000:00:1d.0-1.1.1.1/input0 ... this is most likely caused by e399396a6b0, and fix for that is queued in hid.git as cf601774c9f ("HID: usbhid: fix "always poll" quirk"); I'm planning to send it to Linus' tomorrow, but if you can double-check that it does fix your issue as well, that'd be appreciated. Thanks, -- Jiri Kosina SUSE Labs