Date: Sun, 22 Jun 2003 12:05:31 -0500 (CDT)
From: Kai Germaschewski <kai-germaschewski@uiowa.edu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
cc: Adrian Bunk <bunk@fs.tum.de>, Ed Okerson <eokerson@quicknet.net>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       <trivial@rustcorp.com.au>
Subject: Re: [patch] ixj.c: EXPORT_SYMBOL of static functions
In-Reply-To: <1056280986.2075.8.camel@dhcp22.swansea.linux.org.uk>
Message-ID: <Pine.LNX.4.44.0306221159390.7664-100000@chaos.physics.uiowa.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 880
Lines: 26

On 22 Jun 2003, Alan Cox wrote:

> On Sul, 2003-06-22 at 02:02, Adrian Bunk wrote:
> > drivers/telephony/ixj.c EXPORT_SYMBOL's two static functions.
> > 
> > Does this make any sense or is the patch below OK?
> 
> It's meant to export them. An exported static function is visible to
> other modules.

The exported functions shouldn't normally be declared static though, 
because that means that they will not be available to other modules in the 
built-in case.

So most likely the correct fix is to remove the "static". However, 
ixj_register() still doesn't seem to be used anywhere at all, at least not 
by in-tree modules.

--Kai


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/