Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbdGYDXd (ORCPT ); Mon, 24 Jul 2017 23:23:33 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:33382 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbdGYDXY (ORCPT ); Mon, 24 Jul 2017 23:23:24 -0400 Subject: Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc To: Rob Herring References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-4-git-send-email-j-keerthy@ti.com> <20170724182427.64u5zmr2jl3hk5lh@rob-hp-laptop> CC: , , , , , , , , From: Keerthy Message-ID: Date: Tue, 25 Jul 2017 08:52:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170724182427.64u5zmr2jl3hk5lh@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 47 On Monday 24 July 2017 11:54 PM, Rob Herring wrote: > On Tue, Jul 18, 2017 at 04:27:15PM +0530, Keerthy wrote: >> Add a separate compatible for keystone-k2g soc >> >> Signed-off-by: Keerthy >> --- >> Documentation/devicetree/bindings/gpio/gpio-davinci.txt | 3 ++- >> drivers/gpio/gpio-davinci.c | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> index 5079ba7..1a5c1a2 100644 >> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> @@ -1,7 +1,8 @@ >> Davinci/Keystone GPIO controller bindings >> >> Required Properties: >> -- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" >> +- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio", >> + "ti,keystone-k2g-gpio" > > Reformat to one valid combination per line. Sure Rob. Thanks for reviewing. > >> >> - reg: Physical base address of the controller and the size of memory mapped >> registers. >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index 932f270..a8d8dd9 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -610,6 +610,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) >> static const struct of_device_id davinci_gpio_ids[] = { >> { .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip}, >> { .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip}, >> + { .compatible = "ti,keystone-k2g-gpio", keystone_gpio_get_irq_chip}, >> { /* sentinel */ }, >> }; >> MODULE_DEVICE_TABLE(of, davinci_gpio_ids); >> -- >> 1.9.1 >>