Subject: Re: [PATCH v4 2/2] x86/amd: Fixup cpu_core_id for family17h downcore
 configuration
To: Borislav Petkov <bp@suse.de>
References: <1500888165-2345-1-git-send-email-suravee.suthikulpanit@amd.com>
 <1500888165-2345-3-git-send-email-suravee.suthikulpanit@amd.com>
 <20170724111408.GC28024@nazgul.tnic>
 <c1ed46c7-de8d-07f4-0e0b-68128be8a256@amd.com>
 <20170724144445.GA31300@nazgul.tnic>
 <8e0f6094-f527-3ce7-3652-12df0a8f1ac3@amd.com>
 <20170725055647.GB21822@nazgul.tnic>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, hpa@zytor.com, peterz@infradead.org,
        Yazen.Ghannam@amd.com, Andreas Herrmann <aherrmann@suse.com>
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Message-ID: <484db94c-65b3-47d0-fe87-f6075213307e@amd.com>
Date: Tue, 25 Jul 2017 13:02:49 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170725055647.GB21822@nazgul.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2017 06:02:56.5770 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1734
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1437
Lines: 36

Boris,

On 7/25/17 12:56, Borislav Petkov wrote:
> On Tue, Jul 25, 2017 at 12:51:53PM +0700, Suravee Suthikulpanit wrote:
>> Ok. Sure, it doesn't need be contiguous. But at least the cpu_core_id should
>> represent an ID that make some sense since it is used in the
>> arch/x86/kernel/smpboot.c: match_smt() and some other places. So, if it's
>> invalid for the downcore configuration (i.e. duplicated where it should not
>> be), we should at least clean this up.
> Ah right, we do use it for the SMT siblings. So yes, it should be
> correct for them. And I'm pretty sure the numbers we derive from the
> initial APIC ID are already good enough for that.
>

commit 08b259631b5a1d912af4832847b5642f377d9101
Author: Yazen Ghannam <Yazen.Ghannam@amd.com>
Date:   Sun Feb 5 11:50:22 2017 +0100

     x86/CPU/AMD: Fix Zen SMT topology

     After:

       a33d331761bc ("x86/CPU/AMD: Fix Bulldozer topology")

     our  SMT scheduling topology for Fam17h systems is broken, because
     the ThreadId is included in the ApicId when SMT is enabled.

     So, without further decoding cpu_core_id is unique for each thread
     rather than the same for threads on the same core. This didn't affect
     systems with SMT disabled. Make cpu_core_id be what it is defined to be.

Actually, this commit change how we derive the cpu_core_id fro family17h to use 
CPUID_Fn8000001E_EBX instead of from APIC ID for family17h and later.

Thanks,
Suravee