Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751039AbdGYI0E (ORCPT ); Tue, 25 Jul 2017 04:26:04 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:15346 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdGYI0C (ORCPT ); Tue, 25 Jul 2017 04:26:02 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 25 Jul 2017 01:26:01 -0700 Subject: Re: [PATCH] drm: tegra: add CONFIG_OF dependency To: Arnd Bergmann , Thierry Reding , David Airlie CC: Stephen Boyd , , "Philipp Zabel" , , , References: <20170721161333.3332968-1-arnd@arndb.de> From: Jon Hunter Message-ID: Date: Tue, 25 Jul 2017 09:25:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170721161333.3332968-1-arnd@arndb.de> X-Originating-IP: [10.21.132.162] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 42 On 21/07/17 17:13, Arnd Bergmann wrote: > Without CONFIG_OF, we can run into a build error: > > drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'? > .dt_node_to_map = pinconf_generic_dt_node_to_map_group, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > pinconf_generic_params > drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'? > > This adds an explicit dependency. > > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/tegra/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig > index 2db29d67193d..dc58ab140151 100644 > --- a/drivers/gpu/drm/tegra/Kconfig > +++ b/drivers/gpu/drm/tegra/Kconfig > @@ -3,6 +3,7 @@ config DRM_TEGRA > depends on ARCH_TEGRA || (ARM && COMPILE_TEST) > depends on COMMON_CLK > depends on DRM > + depends on OF > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL Thanks Arnd. I am curious if it can still fail if PINCTRL is not selected in whatever config you are using? That said ... Acked-by: Jon Hunter Cheers Jon -- nvpublic