Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751448AbdGYI10 (ORCPT ); Tue, 25 Jul 2017 04:27:26 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:1638 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbdGYI1Y (ORCPT ); Tue, 25 Jul 2017 04:27:24 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 25 Jul 2017 01:27:24 -0700 Subject: Re: [PATCH 2/4] gpio: tegra: Prefer kcalloc() over kzalloc() with multiplies To: Thierry Reding , Linus Walleij CC: , , References: <20170724145508.7388-1-thierry.reding@gmail.com> <20170724145508.7388-2-thierry.reding@gmail.com> From: Jon Hunter Message-ID: Date: Tue, 25 Jul 2017 09:27:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170724145508.7388-2-thierry.reding@gmail.com> X-Originating-IP: [10.21.132.162] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 39 On 24/07/17 15:55, Thierry Reding wrote: > From: Thierry Reding > > Rather than manually compute the size of an array, pass the number and > element size to kcalloc(). > > Signed-off-by: Thierry Reding > --- > drivers/gpio/gpio-tegra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c > index 63ee221f9be9..1d4df290d7ab 100644 > --- a/drivers/gpio/gpio-tegra.c > +++ b/drivers/gpio/gpio-tegra.c > @@ -621,10 +621,10 @@ static int tegra_gpio_probe(struct platform_device *pdev) > if (tgi->soc->debounce_supported) > tgi->gc.set_config = tegra_gpio_set_config; > > - tgi->bank_info = devm_kzalloc(&pdev->dev, tgi->bank_count * > + tgi->bank_info = devm_kcalloc(&pdev->dev, tgi->bank_count, > sizeof(*tgi->bank_info), GFP_KERNEL); > if (!tgi->bank_info) > - return -ENODEV; > + return -ENOMEM; > > tgi->irq_domain = irq_domain_add_linear(pdev->dev.of_node, > tgi->gc.ngpio, > Acked-by: Jon Hunter Cheers Jon -- nvpublic