Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbdGYJ3f (ORCPT ); Tue, 25 Jul 2017 05:29:35 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:43364 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdGYJ3d (ORCPT ); Tue, 25 Jul 2017 05:29:33 -0400 Subject: Re: [PATCH v5 08/19] coresight tmc: Add helpers for accessing 64bit registers To: Mathieu Poirier References: <1500545849-23724-1-git-send-email-suzuki.poulose@arm.com> <1500545849-23724-9-git-send-email-suzuki.poulose@arm.com> Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Mike Leach From: Suzuki K Poulose Message-ID: <505bb6e9-8f38-bcda-23dd-7ed95ffa143b@arm.com> Date: Tue, 25 Jul 2017 10:29:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 26 On 24/07/17 18:11, Mathieu Poirier wrote: > On 20 July 2017 at 04:17, Suzuki K Poulose wrote: >> Coresight TMC splits 64bit registers into a pair of 32bit registers >> (e.g DBA, RRP, RWP). Provide helpers to read/write to these registers. >> >> Cc: Mathieu Poirier >> Signed-off-by: Suzuki K Poulose >> diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h >> index 51c0185..c78de00 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc.h >> +++ b/drivers/hwtracing/coresight/coresight-tmc.h >> @@ -18,6 +18,7 @@ >> #ifndef _CORESIGHT_TMC_H >> #define _CORESIGHT_TMC_H >> >> +#include > > Is this needed? I recompiled on my side without it and nothing breaks. > I think it is a left over from rebase, where I initially open coded the read/write_relaxed here and then later moved to the coresight-priv.h. So, yes, please could you fix it up when you commit ? Cheers Suzuki