Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751428AbdGYKWF (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Jul 2017 06:22:05 -0400
Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:45173 "EHLO
        mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1750793AbdGYKWD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Jul 2017 06:22:03 -0400
Authentication-Results: ppops.net;
        spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com
Date: Tue, 25 Jul 2017 11:20:57 +0100
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Lee Jones <lee.jones@linaro.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        <linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
        <patches@opensource.wolfsonmicro.com>, <alsa-devel@alsa-project.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 09/12] ASoC: wm9712: add ac97 new bus support
Message-ID: <20170725102057.hblyopxycgz55mr7@localhost.localdomain>
References: <20170724204928.29505-1-robert.jarzmik@free.fr>
 <20170724204928.29505-10-robert.jarzmik@free.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20170724204928.29505-10-robert.jarzmik@free.fr>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0
 suspectscore=8 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015
 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707250165
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 807
Lines: 26

On Mon, Jul 24, 2017 at 10:49:25PM +0200, Robert Jarzmik wrote:
> Add support for the new ac97 bus model, where devices are automatically
> discovered on AC-Links.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> +	} else {
> +		wm9712->ac97 = snd_soc_new_ac97_codec(codec, WM9712_VENDOR_ID,
> +						      WM9712_VENDOR_ID_MASK);
> +		if (IS_ERR(wm9712->ac97)) {
> +			ret = PTR_ERR(wm9712->ac97);
> +			dev_err(codec->dev,
> +				"Failed to register AC97 codec: %d\n", ret);
> +			return ret;
> +		}
> +
> +		regmap = regmap_init_ac97(wm9712->ac97, &wm9712_regmap_config);
> +		if (IS_ERR(regmap)) {
> +			ret = PTR_ERR(regmap);
> +			goto err_free_ac97_codec;

For the 9713 you had this wrapped in an ifdef? Why did it need an
ifdef there but doesn't for this driver?

Thanks,
Charles