Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbdGYL2B (ORCPT ); Tue, 25 Jul 2017 07:28:01 -0400 Received: from mail.izt-labs.de ([82.135.25.162]:51351 "EHLO mail.izt-labs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbdGYL17 (ORCPT ); Tue, 25 Jul 2017 07:27:59 -0400 From: Johannes Poehlmann To: linux-kernel@vger.kernel.org Cc: Johannes Poehlmann , Evgeniy Polyakov , Greg Kroah-Hartman Subject: [PATCH v4 4/5] w1: ds1wm: silence interrupts on HW before claiming the interrupt Date: Tue, 25 Jul 2017 13:27:14 +0200 Message-Id: <1500982035-28838-5-git-send-email-johannes.poehlmann@izt-labs.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1500982035-28838-1-git-send-email-johannes.poehlmann@izt-labs.de> References: <1500982035-28838-1-git-send-email-johannes.poehlmann@izt-labs.de> In-Reply-To: <20170718141502.GA18857@kroah.com> References: <20170718141502.GA18857@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 35 w1: ds1wm: silence interrupts on HW before claiming the interrupt. This way avoid possible invalid interrupts in the initialization phase. Signed-off-by: Johannes Poehlmann Acked-by: Evgeniy Polyakov --- drivers/w1/masters/ds1wm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c index f8a3ba0..5314379 100644 --- a/drivers/w1/masters/ds1wm.c +++ b/drivers/w1/masters/ds1wm.c @@ -509,6 +509,7 @@ static int ds1wm_probe(struct platform_device *pdev) struct ds1wm_driver_data *plat; struct resource *res; int ret; + u8 inten; if (!pdev) return -ENODEV; @@ -562,6 +563,11 @@ static int ds1wm_probe(struct platform_device *pdev) ds1wm_data->int_en_reg_none = (plat->active_high ? DS1WM_INTEN_IAS : 0); ds1wm_data->reset_recover_delay = plat->reset_recover_delay; + /* Mask interrupts, set IAS before claiming interrupt */ + inten = ds1wm_read_register(ds1wm_data, DS1WM_INT_EN); + ds1wm_write_register(ds1wm_data, + DS1WM_INT_EN, ds1wm_data->int_en_reg_none); + if (res->flags & IORESOURCE_IRQ_HIGHEDGE) irq_set_irq_type(ds1wm_data->irq, IRQ_TYPE_EDGE_RISING); if (res->flags & IORESOURCE_IRQ_LOWEDGE) -- 2.1.4