Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751847AbdGYLoC (ORCPT ); Tue, 25 Jul 2017 07:44:02 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34270 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbdGYLoB (ORCPT ); Tue, 25 Jul 2017 07:44:01 -0400 Date: Tue, 25 Jul 2017 13:43:54 +0200 From: Johan Hovold To: Anatolij Gustschin Cc: Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] USB: serial: ftdi_sio: only bind FT232H if UART mode is enabled Message-ID: <20170725114354.GM2729@localhost> References: <1499963125-19412-1-git-send-email-agust@denx.de> <20170719090311.GV29638@localhost> <20170719132327.2ddb8fbe@crub> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170719132327.2ddb8fbe@crub> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1732 Lines: 43 On Wed, Jul 19, 2017 at 01:23:27PM +0200, Anatolij Gustschin wrote: > On Wed, 19 Jul 2017 11:03:11 +0200 > Johan Hovold johan@kernel.org wrote: > > >On Thu, Jul 13, 2017 at 06:25:25PM +0200, Anatolij Gustschin wrote: > >> On FT232H the interface mode can be configured in the EEPROM, > >> and the async UART mode is configured by default. The chip is > >> also in async UART mode if no EEPROM is connected. > >> > >> Check the EEPROM configuration and do not bind as serial device > >> when different interface mode is programmed in the EEPROM. > > > >Thanks for the patch. As you may have inferred from my reply to your MFD > >series, this won't be needed for a while still however. > > > >Also note that some people already use asynchronous FIFO mode using this > >driver (also mentioned in the datasheets as an option) so only binding > >in UART mode would be too restrictive. > > You probably mean asynchronous bitbang mode, not asynchronous FIFO > mode? No, I really meant asynchronous FIFO mode. And as mentioned in the data sheets that can be used with the normal serial (VCP) drivers on both Linux and that other OS. > This bitbang mode can always be set by sending a chip command > (mentioned as software configured in the datasheets) > Could you please point to code in this driver used for non-UART modes? > I don't see such code by a quick glance. There are some quirks for > various JTAG adapters to skip binding as serial port (the ftdi_sio > driver is not used in JTAG operation modes then). Or do people use > usual serial interface to send data in bitbang modes? Exactly. > Async and sync FIFO (FT245) modes however can only be configured via > EEPROM settings, at least for FT232H. Right. Thanks, Johan