Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751845AbdGYLyE (ORCPT ); Tue, 25 Jul 2017 07:54:04 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:37199 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751828AbdGYLyB (ORCPT ); Tue, 25 Jul 2017 07:54:01 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170721161333.3332968-1-arnd@arndb.de> From: Arnd Bergmann Date: Tue, 25 Jul 2017 13:53:59 +0200 X-Google-Sender-Auth: NDhKZbMpHBEAGl4sId2JgaUSKU0 Message-ID: Subject: Re: [PATCH] drm: tegra: add CONFIG_OF dependency To: Jon Hunter Cc: Thierry Reding , David Airlie , Stephen Boyd , Rob Clark , Philipp Zabel , dri-devel , "open list:TEGRA ARCHITECTURE SUPPORT" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 39 On Tue, Jul 25, 2017 at 10:25 AM, Jon Hunter wrote: > > On 21/07/17 17:13, Arnd Bergmann wrote: >> Without CONFIG_OF, we can run into a build error: >> >> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'? >> .dt_node_to_map = pinconf_generic_dt_node_to_map_group, >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> pinconf_generic_params >> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'? >> >> This adds an explicit dependency. >> >> Signed-off-by: Arnd Bergmann >> --- >> drivers/gpu/drm/tegra/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig >> index 2db29d67193d..dc58ab140151 100644 >> --- a/drivers/gpu/drm/tegra/Kconfig >> +++ b/drivers/gpu/drm/tegra/Kconfig >> @@ -3,6 +3,7 @@ config DRM_TEGRA >> depends on ARCH_TEGRA || (ARM && COMPILE_TEST) >> depends on COMMON_CLK >> depends on DRM >> + depends on OF >> select DRM_KMS_HELPER >> select DRM_MIPI_DSI >> select DRM_PANEL > > Thanks Arnd. I am curious if it can still fail if PINCTRL is not > selected in whatever config you are using? I have not run into other those problems in many randconfig builds. Looking at the driver now, I see it has an "#ifdef CONFIG_GENERIC_PINCONF" to handle that case. Arnd