Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbdGYL6K (ORCPT ); Tue, 25 Jul 2017 07:58:10 -0400 Received: from muru.com ([72.249.23.125]:55760 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdGYL6J (ORCPT ); Tue, 25 Jul 2017 07:58:09 -0400 Date: Tue, 25 Jul 2017 04:58:06 -0700 From: Tony Lindgren To: "Reizer, Eyal" Cc: Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sebastian.reichel@collabora.co.uk" Subject: Re: [v3] wlcore: add missing nvs file name info for wilink8 Message-ID: <20170725115805.GU10026@atomide.com> References: <8665E2433BC68541A24DFFCA87B70F5B36409500@DFRE01.ent.ti.com> <20170725102211.GT10026@atomide.com> <8665E2433BC68541A24DFFCA87B70F5B3640DDC7@DFRE01.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B3640DDC7@DFRE01.ent.ti.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 18 * Reizer, Eyal [170725 04:33]: > > From: Tony Lindgren [mailto:tony@atomide.com] > > Hmm so why would we ever even use this bogus nvs file? In addition to > > warning, > > I think we should just ignore the bogus nvs file completely. > > > While it looks bogus, it is still at least a valid mac address and the chip will function > Using it. > Wilink6/7 doesn't have a default mac address in hardware (wilink8 does have one) > so we need to assign one for it so It can work, even if not optimally until configured > using the calibrator tool and a unique mac address is assigned to it. But it's not a unique mac address. What we should do in that case is use a random mac address just like many USB devices do. Regards, Tony