DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9A30613A49
Date: Tue, 25 Jul 2017 14:40:19 +0200
From: Miroslav Lichvar <mlichvar@redhat.com>
To: Santosh Sivaraj <santosh@fossix.org>
Cc: linux-kernel@vger.kernel.org, John Stultz <john.stultz@linaro.org>,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Paul Elder <paul.elder@pitt.edu>
Subject: Re: [PATCH] kselftest/timers: fix build failure
Message-ID: <20170725124019.GC19732@localhost>
References: <20170725075037.2014-1-santosh@fossix.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170725075037.2014-1-santosh@fossix.org>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 542
Lines: 20

On Tue, Jul 25, 2017 at 01:20:37PM +0530, Santosh Sivaraj wrote:
> "message" parameter was not passed to ksft_exit_skip.

It looks like this was a bad merge of 76739256 and 54f57baa, which
added the new parameter to ksft_exit_skip().

> @@ -231,7 +231,7 @@ static void init_test(void)
>  
>  	if (precision > MAX_PRECISION) {
>  		printf("[SKIP]\n");
> -		ksft_exit_skip();
> +		ksft_exit_skip("[SKIP]\n");

To avoid printing "skip" multiple times, I'd suggest to change the
argument of ksft_exit_skip to NULL.

Thanks,

-- 
Miroslav Lichvar