Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbdGYNDk (ORCPT ); Tue, 25 Jul 2017 09:03:40 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:38816 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbdGYNDi (ORCPT ); Tue, 25 Jul 2017 09:03:38 -0400 Subject: Re: [PATCH] sh: remove references to CPU_SUBTYPE_SH7764 To: Paul Bolle , Paul Mundt References: <1363002940.3137.65.camel@x61.thuisdomein> <6feee411-289a-51d9-f413-1f670fafa12a@cogentembedded.com> Cc: linux-sh@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Tue, 25 Jul 2017 16:03:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <6feee411-289a-51d9-f413-1f670fafa12a@cogentembedded.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 33 On 07/25/2017 03:54 PM, Sergei Shtylyov wrote: >> Since release v2.6.29 the tree has a few references to the Kconfig >> symbol CPU_SUBTYPE_SH7764 and the Kconfig macro >> CONFIG_CPU_SUBTYPE_SH7764. But the actual symbol CPU_SUBTYPE_SH7764 was >> never added to the tree. Perhaps no one noticed because these references >> were never used alone. Anyhow, these references serve no purpose and >> can be removed. >> >> Signed-off-by: Paul Bolle >> --- >> Untested: I don't have the hardware. Neither do I have the compiler for >> this architecture at hand. > [...] >> diff --git a/drivers/net/ethernet/renesas/sh_eth.c >> b/drivers/net/ethernet/renesas/sh_eth.c >> index 33e9617..44a3d7b 100644 >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> @@ -1653,7 +1653,6 @@ static int sh_eth_open(struct net_device *ndev) >> >> ret = request_irq(ndev->irq, sh_eth_interrupt, >> #if defined(CONFIG_CPU_SUBTYPE_SH7763) || \ >> - defined(CONFIG_CPU_SUBTYPE_SH7764) || \ >> defined(CONFIG_CPU_SUBTYPE_SH7757) >> IRQF_SHARED, >> #else > > This code is long gone -- what tree is your patch based upon? Oops, didn't realize this mail was from 2013. :-) MBR, Sergei