Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968AbdGYNQk convert rfc822-to-8bit (ORCPT ); Tue, 25 Jul 2017 09:16:40 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:54034 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbdGYNQj (ORCPT ); Tue, 25 Jul 2017 09:16:39 -0400 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Marc Gonzalez Cc: Thomas Gleixner , Marc Zyngier , Jason Cooper , Doug Berger , Florian Fainelli , LKML , Linux ARM , Mason Subject: Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback References: <20170719190734.18566-1-opendmb@gmail.com> <20170719190734.18566-3-opendmb@gmail.com> <7a51555f-8191-9ebd-1f30-7c20f6db9d3f@sigmadesigns.com> <8d29fec9-35b8-c33b-3091-3e9a51c99ed7@gmail.com> Date: Tue, 25 Jul 2017 14:16:36 +0100 In-Reply-To: (Marc Gonzalez's message of "Tue, 25 Jul 2017 15:08:49 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1431 Lines: 37 Marc Gonzalez writes: > irq_gc_mask_disable_reg_and_ack() is not equivalent to > irq_gc_mask_disable_reg() and irq_gc_ack_set_bit(). > > Leave the irq_mask_ack callback undefined, and let the irqchip > framework use irq_mask and irq_ack instead. > > Reported-by: Doug Berger > Fixes: 4bba66899ac6 ("irqchip/tango: Add support for Sigma Designs SMP86xx/SMP87xx interrupt controller") > Signed-off-by: Marc Gonzalez > Cc: stable@vger.kernel.org > --- > As discussed previously, it is acceptable for tango to rely > on mask_ack_irq() doing the right thing(TM). > --- > drivers/irqchip/irq-tango.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/irqchip/irq-tango.c b/drivers/irqchip/irq-tango.c > index bdbb5c0ff7fe..825085cdab99 100644 > --- a/drivers/irqchip/irq-tango.c > +++ b/drivers/irqchip/irq-tango.c > @@ -141,7 +141,6 @@ static void __init tangox_irq_init_chip(struct irq_chip_generic *gc, > for (i = 0; i < 2; i++) { > ct[i].chip.irq_ack = irq_gc_ack_set_bit; > ct[i].chip.irq_mask = irq_gc_mask_disable_reg; > - ct[i].chip.irq_mask_ack = irq_gc_mask_disable_reg_and_ack; > ct[i].chip.irq_unmask = irq_gc_unmask_enable_reg; > ct[i].chip.irq_set_type = tangox_irq_set_type; > ct[i].chip.name = gc->domain->name; > -- What happened to the patch adding the proper combined function? -- M?ns Rullg?rd