Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752412AbdGYOPS convert rfc822-to-8bit (ORCPT ); Tue, 25 Jul 2017 10:15:18 -0400 Received: from us-smtp-delivery-107.mimecast.com ([216.205.24.107]:41439 "EHLO us-smtp-delivery-107.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbdGYOPP (ORCPT ); Tue, 25 Jul 2017 10:15:15 -0400 Subject: Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback From: Marc Gonzalez To: Thomas Gleixner , Marc Zyngier , Jason Cooper CC: Doug Berger , Florian Fainelli , Mans Rullgard , LKML , "Linux ARM" , Mason References: <20170719190734.18566-1-opendmb@gmail.com> <20170719190734.18566-3-opendmb@gmail.com> <7a51555f-8191-9ebd-1f30-7c20f6db9d3f@sigmadesigns.com> <8d29fec9-35b8-c33b-3091-3e9a51c99ed7@gmail.com> Message-ID: <2928ba37-6bb9-1004-bc85-0c13ad513a2c@sigmadesigns.com> Date: Tue, 25 Jul 2017 16:15:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.27.0.114] X-MC-Unique: G9p_go1NNXmVjvXtO-dV-A-2 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 19 On 25/07/2017 15:08, Marc Gonzalez wrote: > irq_gc_mask_disable_reg_and_ack() is not equivalent to > irq_gc_mask_disable_reg() and irq_gc_ack_set_bit(). > > Leave the irq_mask_ack callback undefined, and let the irqchip > framework use irq_mask and irq_ack instead. > > Reported-by: Doug Berger > Fixes: 4bba66899ac6 ("irqchip/tango: Add support for Sigma Designs SMP86xx/SMP87xx interrupt controller") > Signed-off-by: Marc Gonzalez > Cc: stable@vger.kernel.org FWIW, the lockup reported in the thread below disappears once the patch is applied. https://lkml.org/lkml/2016/10/21/709 Regards.