Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbdGYOsf (ORCPT ); Tue, 25 Jul 2017 10:48:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:35440 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752070AbdGYOse (ORCPT ); Tue, 25 Jul 2017 10:48:34 -0400 Subject: Re: [PATCH 2/3] xen: split up xen_hvm_init_shared_info() To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com References: <20170725095013.2939-1-jgross@suse.com> <20170725095013.2939-3-jgross@suse.com> From: Juergen Gross Message-ID: Date: Tue, 25 Jul 2017 16:48:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 274 Lines: 12 On 25/07/17 16:19, Boris Ostrovsky wrote: > On 07/25/2017 05:50 AM, Juergen Gross wrote: >> >> -void __ref xen_hvm_init_shared_info(void) >> +void xen_hvm_init_shared_info(void) > > Why are you dropping __ref? The function no longer calls any __init function. Juergen