Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdGYPO7 (ORCPT ); Tue, 25 Jul 2017 11:14:59 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:33950 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbdGYPO6 (ORCPT ); Tue, 25 Jul 2017 11:14:58 -0400 MIME-Version: 1.0 In-Reply-To: <871sp7rvz4.fsf@belgarion.home> References: <20170720154616.3250481-1-arnd@arndb.de> <20170720155209.3250880-1-arnd@arndb.de> <871sp7rvz4.fsf@belgarion.home> From: Arnd Bergmann Date: Tue, 25 Jul 2017 17:14:57 +0200 X-Google-Sender-Auth: gKr4_yJ8BqgaHbpFlyz4UiV-Bvk Message-ID: Subject: Re: [PATCH 04/12] ARM: sa1100/pxa: fix MTD_XIP build To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Russell King , Russell King , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 28 On Sun, Jul 23, 2017 at 5:53 PM, Robert Jarzmik wrote: > Arnd Bergmann writes: > > Hi Arnd, > >> -#define xip_irqpending() (ICIP & ICMR) >> +/* restored July 2017, this did not build since 2011! */ >> + >> +#define ICIP io_p2v(0x40d00000) >> +#define ICMR io_p2v(0x40d00004) > Okay, I suppose the IO mapping is guaranteed to work, ie. io_p2v() is behaving > correctly when xip_irqpending() is used, right ? I'm not challenging this, I'm > just ensuring this _could_ work (if anybody had the silly idea to make it work > again, and I admit I don't have that much courage). Good thinking ;-) I double-checked this and found that it is correct, and we still map that memory in the same place in pxa_map_io(). >> +#define xip_irqpending() readl(ICIP) & readl(ICMR) > This is not strictly equivalent to (ICIP & ICMR), I would have put for priority > reasons : > +#define xip_irqpending() (readl(ICIP) & readl(ICMR)) Ok, I've changed that and will resend. Arnd